Skip to content

fix(codex): stop forcing low text verbosity #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitksingh1490 merged 3 commits into from
Mar 8, 2026
+0 −37
Merged

fix(codex): stop forcing low text verbosity #2501

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b0fc46
fix(codex): stop forcing low text verbosity
ssddOnTop Mar 8, 2026
7b7d9bf
fix(codex): remove text verbosity override tests
ssddOnTop Mar 8, 2026
1e9a0e1
Merge branch 'main' into fix/unsupported-effort-on-codex-models
ssddOnTop Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions crates/forge_repo/src/provider/openai_responses/codex_transformer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ impl Transformer for CodexTransformer {
includes.push(oai::IncludeEnum::ReasoningEncryptedContent);
}

// Force text verbosity to Low for concise codex output
let text = request.text.get_or_insert(oai::ResponseTextParam {
format: oai::TextResponseFormatConfiguration::Text,
verbosity: None,
});
text.verbosity = Some(oai::Verbosity::Low);

if let Some(reasoning) = request.reasoning.as_mut() {
reasoning.effort = Some(oai::ReasoningEffort::High);
reasoning.summary = Some(oai::ReasoningSummary::Auto);
Expand Down Expand Up @@ -149,36 +142,6 @@ mod tests {
);
}

#[test]
fn test_codex_transformer_sets_text_verbosity_low() {
let fixture = fixture();
let mut transformer = CodexTransformer;
let actual = transformer.transform(fixture);

let expected = Some(oai::Verbosity::Low);
assert_eq!(
actual.text.as_ref().and_then(|t| t.verbosity.clone()),
expected
);
}

#[test]
fn test_codex_transformer_overrides_text_verbosity_to_low() {
let mut fixture = fixture();
fixture.text = Some(oai::ResponseTextParam {
format: oai::TextResponseFormatConfiguration::Text,
verbosity: Some(oai::Verbosity::High),
});
let mut transformer = CodexTransformer;
let actual = transformer.transform(fixture);

let expected = Some(oai::Verbosity::Low);
assert_eq!(
actual.text.as_ref().and_then(|t| t.verbosity.clone()),
expected
);
}

#[test]
fn test_codex_transformer_no_reasoning_unchanged() {
let fixture = fixture();
Expand Down
Loading