fix(retry): treat request-level errors as retryable#2543
Merged
tusharmath merged 2 commits intomainfrom Mar 12, 2026
Merged
Conversation
github-actions
Bot
added
the
type: fix
tusharmath
force-pushed
the
fix/retry-unexpected-eof
branch
2 times, most recently
from
d504005 to
73ae220
Compare
The UnexpectedEof error from rustls (peer closed connection without TLS close_notify) surfaces as a reqwest::Error with is_request() == true, which was not covered by the existing is_timeout() || is_connect() check. Adding is_request() retries all request-level transport failures including this TLS close_notify case. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
tusharmath
force-pushed
the
fix/retry-unexpected-eof
branch
from
0e2deea to
9e63198
Compare
tusharmath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat request-level reqwest errors as retryable, fixing the
peer closed connection without sending TLS close_notifyerror from the ChatGPT codex endpoint.Context
Requests to
https://chatgpt.com/backend-api/codex/responseswere failing permanently with:This error surfaces as a
reqwest::Errorwithis_request() == true. The existing retry check only coveredis_timeout()andis_connect(), so these request-level transport failures were never retried.Changes
|| e.is_request()tois_req_transport_error— a one-line fixTesting
cargo insta test --accept -p forge_repoLinks