fix(gpt-5.3-codex-spark): support tool call arguments in done event without deltas#2558
Merged
tusharmath merged 5 commits intomainfrom Mar 14, 2026
Merged
fix(gpt-5.3-codex-spark): support tool call arguments in done event without deltas#2558tusharmath merged 5 commits intomainfrom
tusharmath merged 5 commits intomainfrom
Conversation
github-actions
Bot
added
the
type: fix
…nsesResponseRepository tests
amitksingh1490
changed the title
tusharmath
reviewed
Mar 14, 2026
| @@ -154,6 +154,12 @@ impl IntoDomain for oai::Response { | |||
| #[derive(Default)] | |||
| struct CodexStreamState { | |||
| output_index_to_tool_call: HashMap<u32, (ToolCallId, ToolName)>, | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| output_index_to_tool_call: HashMap<u32, (ToolCallId, ToolName)>, | |
| output_index_to_tool_call: HashMap<ToolCallIndex, (ToolCallId, ToolName)>, |
tusharmath
reviewed
Mar 14, 2026
| /// skipped to avoid duplication. When no deltas are received (e.g. the | ||
| /// Spark model sends arguments only in the `done` event), we must emit | ||
| /// them from the `done` handler. | ||
| output_indices_with_deltas: HashSet<u32>, |
Collaborator
There was a problem hiding this comment.
Suggested change
| output_indices_with_deltas: HashSet<u32>, | |
| received_toolcall_deltas: HashSet<ToolCallIndex>, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.