Skip to content

fix(config): move currency keys above [reasoning] table header#3041

Merged
amitksingh1490 merged 1 commit intotailcallhq:mainfrom
karoldyro:fix/currency-config-scoping
Apr 16, 2026
Merged

fix(config): move currency keys above [reasoning] table header#3041
amitksingh1490 merged 1 commit intotailcallhq:mainfrom
karoldyro:fix/currency-config-scoping

Conversation

@karoldyro
Copy link
Copy Markdown
Contributor

currency_symbol and currency_conversion_rate were added below the [reasoning] table header in #2887. TOML scopes them as reasoning.*, but the fields are defined on the root ForgeConfig struct — silently dropped during deserialization, defaulting to "" / 0.0.

Fix: move both keys above the first table header so they're parsed as top-level config.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the type: fix Iterations on existing features or infrastructure. label Apr 16, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 16, 2026

CLA assistant check
All committers have signed the CLA.

@amitksingh1490 amitksingh1490 enabled auto-merge (squash) April 16, 2026 09:59
@amitksingh1490 amitksingh1490 merged commit 8a87531 into tailcallhq:main Apr 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Iterations on existing features or infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants