Emit @keyframes in prefixed setup#16850
Merged
philipp-spiess merged 1 commit intomainfrom Feb 27, 2025
Merged
Conversation
philipp-spiess
force-pushed
the
fix/keyframes
branch
from
0dc7d1b to
d987f9b
Compare
thecrypticace
approved these changes
Feb 27, 2025
|
Still have issues with animations not working with prefix. |
Contributor
Author
|
@Atydin Mind creating a new issue and attaching a reproduction setup? |
|
same here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16829
We were only adding keyframes used in variables starting with
--animate(without adding a potential prefix).Test plan