Allow multiples of .25 in aspect-* fractions#19688
Conversation
If you want something more crazy, then you would still have to use `aspect-[1.23/4.56]`. Using multiples of `.25` matches how the other bare values like `w-2.5` work.
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThis pull request adds support for decimal fractions in aspect-ratio utilities. The CHANGELOG documents the addition of multiples of 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
Hey @RobinMalfait, thanks for picking this up! Would you mind adding a |
This PR reduces the restrictions of the
aspect-*utilities when dealing with fractional values.Up until now, the numbers had to be positive integers, so
aspect-1/2was valid, butaspect-8.5/11was not.This PR allows for any multiple of
.25as a valid value, soaspect-8.5/11is now valid, butaspect-8.3/11is not, this will still requireaspect-[8.3/11]arbitrary value syntax to be valid.This behavior of allowing multiples of
.25is consistent with other utilities that handle bare values such asw-2.5.Test plan
aspect-8.5/11Fixes: #19663
Closes: #19680, #19669