fix(rpc):use tsApplyMemoryAllowed to control memory alloc while apply msg.#29618
Merged
Conversation
xiao-77
requested review from
dapan1121,
guanshengliang and
hzcheng
as code owners
guanshengliang
approved these changes
Jan 21, 2025
kailixu
reviewed
Jan 21, 2025
| int64_t alloced = -1; | ||
|
|
||
| if (alloced > tsQueueMemoryAllowed) { | ||
| alloced = atomic_add_fetch_64(&tsQueueMemoryUsed, size + dataSize); |
Contributor
There was a problem hiding this comment.
这个逻辑永远都进不来，tsQueueMemoryUsed 应该是控制不住。看一下，是期望的改动吗？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.