feat: [TS-6100] Process SCMCreateStreamReq#30940
Merged
Simon9997 merged 1 commit intofeat/TS-6100-3.0from Apr 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy “stream event type” functionality and refactors the processing of SCMCreateStreamReq by adding new fields and adjusting serialization/deserialization flows. Key changes include:
- Updates in SCMCreateStreamReq encoding/decoding (e.g. new fields streamId, flags, tsmaId, placeHolderBitmap, and expanded sliding trigger parameters).
- Removal of legacy stream node tests and related node types, along with updates to built-in function classifications.
- Cleaning up client and parser structures by removing deprecated fields (e.g. streamRunHistory) and stream‐related fields in planner and nodes headers.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| source/libs/nodes/test/nodesCloneTest.cpp | Removed test cases for stream session/window nodes; verify test coverage. |
| source/libs/nodes/src/nodesUtilFuncs.c | Removed calls to free SCMCreateStreamReq in node destruction; check memory management. |
| source/libs/nodes/src/nodesMsgFuncs.c | Deleted functions related to stream event type and stream partition nodes. |
| source/libs/nodes/src/nodesCodeFuncs.c | Adjusted JSON conversion keys and removed outdated stream event type code. |
| source/libs/function/src/functionMgt.c & builtins.c | Updated built-in function classifications; removal of forbid-stream flag. |
| source/common/src/msg/streamMsg.c | Updated SCMCreateStreamReq serialization/deserialization with new fields. |
| source/client/src/clientMain.c & related headers | Removed deprecated field streamRunHistory and cleaned up API struct initializations. |
Comments suppressed due to low confidence (4)
source/libs/nodes/test/nodesCloneTest.cpp:261
- The removal of test cases for stream session/window nodes is significant; please ensure that the new SCMCreateStreamReq functionality is covered by updated tests elsewhere.
TEST_F(NodesCloneTest, physiStreamSemiSessionWinodw) { ... }
source/libs/nodes/src/nodesUtilFuncs.c:1553
- The explicit freeing of pReq has been removed here; please confirm that memory allocated for SCMCreateStreamReq is now handled appropriately elsewhere to avoid potential memory leaks.
tFreeSCMCreateStreamReq(pStmt->pReq);
source/libs/function/src/builtins.c:2049
- [nitpick] The built-in function classifications have been updated by removing the FUNC_MGT_FORBID_STREAM_FUNC flag; please double-check that this change aligns with intended restrictions for stream functions.
.classification = FUNC_MGT_AGG_FUNC | FUNC_MGT_FORBID_STREAM_FUNC | FUNC_MGT_FORBID_SYSTABLE_FUNC,
source/common/src/msg/streamMsg.c:1527
- New sliding trigger fields (intervalUnit, slidingUnit, offsetUnit, soffsetUnit, and precision) have been added; please verify that the encoding order exactly matches the decoding order to avoid data inconsistencies.
TAOS_CHECK_EXIT(tEncodeI8(pEncoder, pReq->trigger.sliding.intervalUnit));
a95f6cb to
cc8c6d3
Compare
support placeHolderBitmap and interval offset in stream trigger. remove useless code.
cc8c6d3 to
6ae805b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.