Skip to content

fix: conditionally copy scripts and update configuration instructions for non-lite package mode#33188

Merged
feici02 merged 2 commits intomainfrom
fix/install-lite
Oct 10, 2025
Merged

fix: conditionally copy scripts and update configuration instructions for non-lite package mode#33188
feici02 merged 2 commits intomainfrom
fix/install-lite

Conversation

@tomchon
Copy link
Copy Markdown
Contributor

@tomchon tomchon commented Oct 9, 2025

修改 lite 的打印信息,移除一些不必要的提醒和打印

@tomchon tomchon requested a review from feici02 as a code owner October 9, 2025 10:35
@tomchon tomchon requested a review from Copilot October 9, 2025 10:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the installation script to conditionally handle scripts and configuration instructions based on package mode, specifically excluding certain operations for "lite" package mode.

  • Conditionally copy start-all.sh and stop-all.sh scripts only for non-lite packages
  • Skip taos_malloc.sh script copying for lite packages
  • Provide simplified configuration instructions for lite package mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packaging/tools/install.sh
@tomchon tomchon changed the title fix: conditionally copy scripts and update configuration instructions… fix: conditionally copy scripts and update configuration instructions for non-lite package mode Oct 9, 2025
Signed-off-by: WANG Xu <feici02@outlook.com>
@tomchon tomchon requested a review from Copilot October 10, 2025 06:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +291 to +292
if [[ -f ${script_dir}/bin/${set_malloc_bin} && "${verType}" != "client" ]]; then
${csudo}cp -r ${script_dir}/bin/${set_malloc_bin} ${install_main_dir}/bin
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The condition structure has been changed from separate conditions to a compound condition with &&. Consider breaking this into nested if statements for better readability and easier debugging.

Suggested change
if [[ -f ${script_dir}/bin/${set_malloc_bin} && "${verType}" != "client" ]]; then
${csudo}cp -r ${script_dir}/bin/${set_malloc_bin} ${install_main_dir}/bin
if [ -f ${script_dir}/bin/${set_malloc_bin} ]; then
if [ "${verType}" != "client" ]; then
${csudo}cp -r ${script_dir}/bin/${set_malloc_bin} ${install_main_dir}/bin
fi

Copilot uses AI. Check for mistakes.
@feici02 feici02 merged commit c052fa4 into main Oct 10, 2025
@minhuinie minhuinie deleted the fix/install-lite branch February 4, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants