fix: conditionally copy scripts and update configuration instructions for non-lite package mode#33188
fix: conditionally copy scripts and update configuration instructions for non-lite package mode#33188
Conversation
… for non-lite package mode
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the installation script to conditionally handle scripts and configuration instructions based on package mode, specifically excluding certain operations for "lite" package mode.
- Conditionally copy start-all.sh and stop-all.sh scripts only for non-lite packages
- Skip taos_malloc.sh script copying for lite packages
- Provide simplified configuration instructions for lite package mode
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: WANG Xu <feici02@outlook.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if [[ -f ${script_dir}/bin/${set_malloc_bin} && "${verType}" != "client" ]]; then | ||
| ${csudo}cp -r ${script_dir}/bin/${set_malloc_bin} ${install_main_dir}/bin |
There was a problem hiding this comment.
[nitpick] The condition structure has been changed from separate conditions to a compound condition with &&. Consider breaking this into nested if statements for better readability and easier debugging.
| if [[ -f ${script_dir}/bin/${set_malloc_bin} && "${verType}" != "client" ]]; then | |
| ${csudo}cp -r ${script_dir}/bin/${set_malloc_bin} ${install_main_dir}/bin | |
| if [ -f ${script_dir}/bin/${set_malloc_bin} ]; then | |
| if [ "${verType}" != "client" ]; then | |
| ${csudo}cp -r ${script_dir}/bin/${set_malloc_bin} ${install_main_dir}/bin | |
| fi |
修改 lite 的打印信息,移除一些不必要的提醒和打印