fix: memleak

[facetosea]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @facetosea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses several identified memory leaks across different components of the codebase. The changes primarily focus on ensuring that dynamically allocated memory is correctly freed, particularly for DECIMAL data types during object destruction and within various error handling branches of the command message building and node allocation logic. These fixes enhance the overall stability and resource management of the system.

Highlights

• Decimal Type Memory Management: Ensured proper memory deallocation for TSDB_DATA_TYPE_DECIMAL in tvariant.c during variant destruction and in tfill.c during fill information cleanup, preventing potential leaks for this data type.
• Robust Error Path Memory Cleanup: Implemented explicit memory freeing in various error handling paths within nodesUtilFuncs.c and parTranslater.c to prevent memory leaks when operations fail during node allocation or command message building.
• Compiler Warning Suppression: Wrapped calls to functions like setNotFillColumn and doFillOneCol with TAOS_UNUSED in tfill.c to suppress compiler warnings about unused return values, improving code hygiene without altering logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily addresses memory leaks by ensuring dynamically allocated memory is properly freed in various destruction and error-handling paths. Specifically, it adds cleanup for TSDB_DATA_TYPE_DECIMAL in taosVariantDestroy and taosDestroyFillInfo, and fixes memory leaks in error paths in buildCmdMsg. Additionally, it improves code quality by handling unused return values with TAOS_UNUSED.

My review focuses on the correctness of these fixes. One area in tfill.c could be improved for clarity and to avoid a potential compiler warning, for which I've left a specific comment.