Conversation
Summary of ChangesHello @zitsen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the accuracy of the Xnode documentation by updating the default port number for the taosx GRPC service. The changes ensure that both the parameter descriptions and the provided SQL examples correctly reference port 6055, thereby improving clarity and preventing potential configuration issues for users. The updates are applied to both English and Chinese versions of the relevant documentation page. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR updates the xnode port number from 6050 to 6055 in documentation for both Chinese and English versions, reflecting a change in the default taosx GRPC service port.
- Updated port references from 6050 to 6055 in parameter descriptions and code examples
- Added clarification that the port refers to the taosx GRPC service with default value 6055
- Applied changes consistently across both language versions of the documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/zh/14-reference/03-taos-sql/94-datain.md | Updated xnode port from 6050 to 6055 in Chinese documentation with added context about taosx GRPC port |
| docs/en/14-reference/03-taos-sql/94-datain.md | Updated xnode port from 6050 to 6055 in English documentation with added context about taosx GRPC service |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #### Parameter Description | ||
|
|
||
| - **url**: The address of the Xnode node, in the format `host:port` | ||
| - **url**: The address of the Xnode node, in the format `host:port` with port to taosx GRPC service (6055 by default) |
There was a problem hiding this comment.
The phrase "with port to taosx GRPC service" is grammatically awkward. Consider rephrasing to "with port for the taosx GRPC service" or "where port refers to the taosx GRPC service port" for better clarity.
| - **url**: The address of the Xnode node, in the format `host:port` with port to taosx GRPC service (6055 by default) | |
| - **url**: The address of the Xnode node, in the format `host:port`, where `port` refers to the taosx GRPC service port (6055 by default) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the default port for XNODE from 6050 to 6055 in the CREATE XNODE documentation for both English and Chinese versions, clarifying that this port is for the taosx GRPC service. I've added comments regarding inconsistencies in other examples within the same documentation files. Additionally, it might be worth checking related test files (e.g., test/cases/42-Xnode/test_xnode.py, test/cases/42-Xnode/test_xnode_lifecycle.py) which still seem to use the old port 6050 for CREATE XNODE commands. Updating them in a subsequent PR would ensure consistency across the codebase.
| #### Parameter Description | ||
|
|
||
| - **url**: The address of the Xnode node, in the format `host:port` | ||
| - **url**: The address of the Xnode node, in the format `host:port` with port to taosx GRPC service (6055 by default) |
There was a problem hiding this comment.
While this line and the CREATE XNODE examples have been correctly updated to use port 6055, other examples in this file remain inconsistent. For instance, the SHOW XNODES example output on line 58 and the DROP XNODE example on line 103 still reference the old port 6050. To ensure consistency and prevent user confusion, it's recommended to update all port references in this document to 6055.
| #### 参数说明 | ||
|
|
||
| - **url**: Xnode 节点的地址，格式为 `host:port` | ||
| - **url**: Xnode 节点的地址，格式为 `host:port`，端口号为 taosx GRPC 端口（默认 6055） |
There was a problem hiding this comment.
While this line and the CREATE XNODE examples have been correctly updated to use port 6055, other examples in this file remain inconsistent. For instance, the SHOW XNODES example output on line 58 and the DROP XNODE example on line 103 still reference the old port 6050. To ensure consistency and prevent user confusion, it's recommended to update all port references in this document to 6055.
No description provided.