fix(stream/fetch): fix stream data fetching from runner

[stephenkgu]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link
  https://project.feishu.cn/taosdata_td/68d89fef3cf13be3ff3878ca/detail/6659832860

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @stephenkgu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug related to stream data fetching from the runner. The changes involve a minor adjustment to the serialization logic for stream fetch requests, specifically regarding pseudo function values, and a more significant fix in the external window operator's output aggregation. The latter ensures that window processing correctly advances when output thresholds are met, preventing potential data inconsistencies or infinite loops in stream processing.

Highlights

• Stream Request Serialization: Modified the serialization of "SResFetchReq" by commenting out the "pReq->reset" condition when calling "tSerializeStRtFuncInfo". This change likely ensures that "needStreamPesudoFuncVals" is always considered for serialization, regardless of the "reset" flag, addressing a potential issue in how stream pseudo function values are handled.
• External Window Operator Output Logic: Corrected the "extWinAggOutputRes" function to increment "pExtW->outputWinId" before breaking the loop when the result block reaches its threshold. This ensures that the next call to the function correctly processes the subsequent window, preventing reprocessing or skipping of windows.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to fix issues related to stream data fetching. The changes involve modifying the serialization logic for resource fetch requests and correcting loop control in the external window operator. My review focuses on improving code clarity and maintainability.