fix: allow_datetime cannot be set during create user

[localvar]

Description

fix: allow_datetime cannot be set during create user

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @localvar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that prevented allow_datetime settings from being correctly configured when creating new users. By fixing a simple but impactful typo in a loop condition, the PR ensures that time-based access restrictions can now be accurately processed and applied, resolving an issue where such settings were previously ignored.

Highlights

• Bug Fix: Corrected a logical error in the mndCreateUser function where the loop intended to process SDateTimeRange items incorrectly used numIpRanges instead of numTimeRanges. This fix ensures that allow_datetime settings are properly applied during user creation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a high-severity bug in the user creation logic. The loop for setting datetime whitelists was using an incorrect boundary, which could lead to out-of-bounds memory access or failure to set the whitelists. The fix is accurate. I've also added a minor suggestion to remove an unused variable for code cleanup.

[Copilot]

Pull request overview

This PR fixes a critical bug in user creation where the wrong loop counter was used when processing datetime ranges. The issue was a copy-paste error where numIpRanges was incorrectly used instead of numTimeRanges when iterating over time range whitelist items.

Key changes:

• Corrected loop condition from pCreate->numIpRanges to pCreate->numTimeRanges when iterating over time ranges during user creation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.