fix: set max value of supportVnodes from 4096 to 1024.#34497
fix: set max value of supportVnodes from 4096 to 1024.#34497guanshengliang merged 2 commits into3.3.6from
Conversation
Summary of ChangesHello @xiao-77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the system's configuration by lowering the upper bound for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This pull request reduces the maximum allowed value for the supportVnodes configuration parameter from 4096 to 1024. The supportVnodes parameter controls the maximum number of vnodes (virtual nodes) that a dnode (data node) can support in TDengine.
Changes:
- Updated the maximum value constraint in the code from 4096 to 1024
- Updated Chinese documentation to reflect the new maximum value
- Updated English documentation to reflect the new maximum value
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/common/src/tglobal.c | Changed the max value constraint for supportVnodes from 4096 to 1024 in the configuration definition |
| docs/zh/14-reference/01-components/01-taosd.md | Updated Chinese documentation to show new maximum value of 1024 |
| docs/en/14-reference/01-components/01-taosd.md | Updated English documentation to show new maximum value of 1024 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request reduces the maximum value of the supportVnodes configuration parameter from 4096 to 1024. The change is consistently applied across the C source code and the documentation in both English and Chinese. This is a good fix to prevent potential resource issues with a high number of vnodes. The changes are correct and look good to me.
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.