Skip to content

fix: set max value of supportVnodes from 4096 to 1024.#34497

Merged
guanshengliang merged 2 commits into3.3.6from
fix/336/max-supportVnodes
Feb 5, 2026
Merged

fix: set max value of supportVnodes from 4096 to 1024.#34497
guanshengliang merged 2 commits into3.3.6from
fix/336/max-supportVnodes

Conversation

@xiao-77
Copy link
Copy Markdown
Contributor

@xiao-77 xiao-77 commented Feb 4, 2026

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings February 4, 2026 03:01
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @xiao-77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the system's configuration by lowering the upper bound for the supportVnodes parameter. This adjustment is crucial for maintaining system stability and resource management, and the corresponding documentation has been updated across multiple languages to accurately reflect this new constraint.

Highlights

  • Configuration Parameter Update: The maximum allowed value for the supportVnodes configuration parameter has been reduced from 4096 to 1024. This change is applied directly in the source code where the parameter is defined.
  • Documentation Synchronization: The English and Chinese documentation for the supportVnodes parameter has been updated to reflect the new maximum value of 1024, ensuring consistency with the code changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/en/14-reference/01-components/01-taosd.md
    • Updated the maximum value for supportVnodes from 4096 to 1024 in the English documentation.
  • docs/zh/14-reference/01-components/01-taosd.md
    • Updated the maximum value for supportVnodes from 4096 to 1024 in the Chinese documentation.
  • source/common/src/tglobal.c
    • Modified the cfgAddInt32 function call for supportVnodes to set its maximum allowed value to 1024.
Activity
  • The pull request was opened by xiao-77 with a clear intent to fix the maximum value of supportVnodes.
  • Changes were made to both the core configuration file and its corresponding English and Chinese documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reduces the maximum allowed value for the supportVnodes configuration parameter from 4096 to 1024. The supportVnodes parameter controls the maximum number of vnodes (virtual nodes) that a dnode (data node) can support in TDengine.

Changes:

  • Updated the maximum value constraint in the code from 4096 to 1024
  • Updated Chinese documentation to reflect the new maximum value
  • Updated English documentation to reflect the new maximum value

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
source/common/src/tglobal.c Changed the max value constraint for supportVnodes from 4096 to 1024 in the configuration definition
docs/zh/14-reference/01-components/01-taosd.md Updated Chinese documentation to show new maximum value of 1024
docs/en/14-reference/01-components/01-taosd.md Updated English documentation to show new maximum value of 1024

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces the maximum value of the supportVnodes configuration parameter from 4096 to 1024. The change is consistently applied across the C source code and the documentation in both English and Chinese. This is a good fix to prevent potential resource issues with a high number of vnodes. The changes are correct and look good to me.

@guanshengliang guanshengliang merged commit a18a88c into 3.3.6 Feb 5, 2026
22 of 26 checks passed
@guanshengliang guanshengliang deleted the fix/336/max-supportVnodes branch February 5, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants