chore: update version to v3.7.8 and modify notify tests for enterprise edition#353
chore: update version to v3.7.8 and modify notify tests for enterprise edition#353
Conversation
Summary of ChangesHello @huskar-t, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a version update and an adjustment to the test suite. The project's internal commit identifier has been updated, and a test case for user whitelist notifications has been refactored to ensure it only runs in enterprise environments, preventing test failures in non-enterprise setups where the feature is unavailable. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the version and modifies the notification tests to be conditional for the enterprise edition. However, the changes to the test introduce a critical logical error by reordering operations, causing the test to fail. Additionally, the use of t.Skip is incorrect as it would cause subsequent test logic to be skipped unintentionally. I've provided a detailed comment with a code suggestion to fix these issues and improve the test structure.
There was a problem hiding this comment.
Pull request overview
This PR updates the driver version to v3.7.8 and restructures the notify test to handle enterprise-specific features properly. The changes separate the whitelist testing functionality to only run when the enterprise edition environment variable is set.
- Version update to v3.7.8 with new commit hash
- Whitelist test moved after user drop operation with enterprise edition check
- Import added for testenv package to support enterprise edition detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| version/version.go | Updates version tag to v3.7.8 and commit hash to 96e0e3b |
| wrapper/notify_test.go | Moves whitelist test section and adds enterprise edition check using testenv.IsEnterpriseTest() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 85.67% 85.74% +0.07%
==========================================
Files 83 83
Lines 9149 9149
==========================================
+ Hits 7838 7845 +7
+ Misses 796 792 -4
+ Partials 515 512 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
chore: update version to v3.7.8 and modify notify tests for enterprise edition
Issue(s)
Checklist
Please check the items in the checklist if applicable.