Conversation
|
*beep* *bop* Details643 [ ] syntax-error
12 E701 [ ] multiple-statements-on-one-line-colon
9 E902 [ ] io-error
7 W293 [ ] blank-line-with-whitespace
5 E702 [ ] multiple-statements-on-one-line-semicolon
1 B019 [ ] cached-instance-method
1 RET506 [*] superfluous-else-raise
Found 678 errors.
[*] 1 fixable with the `--fix` option.
Complete output(might be large): Detailsbenchmarks/benchmark_base.py:58:9: RET506 [*] Unnecessary `else` after `raise` statement
benchmarks/opacities_opacity.py:1:1: E902 No such file or directory (os error 2)
benchmarks/opacities_opacity_state.py:21:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
benchmarks/transport_geometry_calculate_distances.py:1:1: E902 No such file or directory (os error 2)
benchmarks/transport_montecarlo_estimators_radfield_estimator_calcs.py:1:1: E902 No such file or directory (os error 2)
benchmarks/transport_montecarlo_interaction.py:1:1: E902 No such file or directory (os error 2)
benchmarks/transport_montecarlo_main_loop.py:1:1: E902 No such file or directory (os error 2)
benchmarks/transport_montecarlo_packet_trackers.py:1:1: E902 No such file or directory (os error 2)
benchmarks/transport_montecarlo_single_packet_loop.py:1:1: E902 No such file or directory (os error 2)
benchmarks/transport_montecarlo_vpacket.py:1:1: E902 No such file or directory (os error 2)
Found 10 errors.
[*] 1 fixable with the `--fix` option.
|
There was a problem hiding this comment.
Pull request overview
Simplifies the ASV benchmark suite by removing unstable/unsupported benchmarks, keeping focus on the currently supported run_tardis workflow (with/without packet tracking).
Changes:
- Removed multiple Monte Carlo / opacities / spectrum / geometry benchmark modules that have been failing.
- Deleted an unused benchmark YAML config under
benchmarks/data/. - Slimmed down
BenchmarkBaseto remove heavy simulation helpers and keep only config-loading utilities (including rpacket tracking config).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| benchmarks/transport_montecarlo_vpacket.py | Removed vpacket tracing benchmarks. |
| benchmarks/transport_montecarlo_single_packet_loop.py | Removed single-packet-loop benchmark. |
| benchmarks/transport_montecarlo_packet_trackers.py | Removed packet tracker benchmarks. |
| benchmarks/transport_montecarlo_main_loop.py | Removed Monte Carlo main loop benchmark. |
| benchmarks/transport_montecarlo_interaction.py | Removed interaction event benchmarks. |
| benchmarks/transport_montecarlo_estimators_radfield_estimator_calcs.py | Removed radfield estimator calcs benchmark. |
| benchmarks/transport_geometry_calculate_distances.py | Removed geometry distance calculation benchmarks. |
| benchmarks/spectrum_formal_integral.py | Removed formal integral benchmarks. |
| benchmarks/opacities_opacity_state.py | Removed opacity state initialization benchmark. |
| benchmarks/opacities_opacity.py | Removed opacity calculation benchmarks. |
| benchmarks/data/tardis_configv1_benchmark.yml | Removed benchmark-specific config YAML. |
| benchmarks/benchmark_base.py | Removed simulation/packet helper machinery; kept config helpers and added a cached tracking-enabled config property. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
*beep* *bop* Hi, human. The Click here to see your results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3420 +/- ##
==========================================
- Coverage 70.73% 70.54% -0.20%
==========================================
Files 213 213
Lines 17259 17259
==========================================
- Hits 12209 12175 -34
- Misses 5050 5084 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Will need to be modified to point to the correct file (once Atharva's PR is merged)
connor-mcclellan
left a comment
There was a problem hiding this comment.
Leave opacities_opacity_state.py and spectrum_formal_integral.py as-is for now
📝 Description
Type: 🪲
bugfix| 🎢infrastructureBenchmarks have consistently been failing and causing problems. The only API we are consistently supporting right now is the classic
run_tardisand the workflows. For now, the benchmarks are simplified to justrun_tardiswith and without packet tracking.Running them locally has been prevented by the same bug that is affecting docstr-cov, #3419
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel