[GSOC] fix test_convergence_plot_command_line #3433
Open
Aaryan-Dadu wants to merge 1 commit intotardis-sn:masterfrom
Open
[GSOC] fix test_convergence_plot_command_line #3433Aaryan-Dadu wants to merge 1 commit intotardis-sn:masterfrom
Aaryan-Dadu wants to merge 1 commit intotardis-sn:masterfrom
Conversation
- previously for the environment only is_notebook was set to False, but under the VS Code test interface allows_widget_display still evaluated to True. - mocking allows_widget_display to False to correct this bug
andrewfullard
approved these changes
Feb 16, 2026
Contributor
andrewfullard
left a comment
There was a problem hiding this comment.
Nice fix, works for me
Contributor
|
*beep* *bop* Details3 F811 [*] redefined-while-unused
1 I001 [*] unsorted-imports
Found 4 errors.
[*] 4 fixable with the `--fix` option.
Complete output(might be large): Detailstardis/visualization/tools/tests/test_convergence_plot.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/tests/test_convergence_plot.py:14:25: F811 [*] Redefinition of unused `defaultdict` from line 3
tardis/visualization/tools/tests/test_convergence_plot.py:15:32: F811 [*] Redefinition of unused `go` from line 6
tardis/visualization/tools/tests/test_convergence_plot.py:16:30: F811 [*] Redefinition of unused `u` from line 8
Found 4 errors.
[*] 4 fixable with the `--fix` option.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfixfixes #3417
📌 Resources
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabelAI Usage
None