Skip to content

Comments

[GSOC] fix test_convergence_plot_command_line #3433

Open
Aaryan-Dadu wants to merge 1 commit intotardis-sn:masterfrom
Aaryan-Dadu:bug
Open

[GSOC] fix test_convergence_plot_command_line #3433
Aaryan-Dadu wants to merge 1 commit intotardis-sn:masterfrom
Aaryan-Dadu:bug

Conversation

@Aaryan-Dadu
Copy link
Contributor

@Aaryan-Dadu Aaryan-Dadu commented Feb 16, 2026

📝 Description

Type: 🪲 bugfix

fixes #3417

  • previously for the environment only is_notebook was set to False, but under the VS Code test interface allows_widget_display still evaluated to True.
  • mocking allows_widget_display to False to correct this bug, now the test passes on both CLI and vscode test interface
Screenshot From 2026-02-17 02-35-35

📌 Resources

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

AI Usage

None

- previously for the environment only is_notebook was set to False, but under the VS Code test interface allows_widget_display still evaluated to True.
- mocking allows_widget_display to False to correct this bug
@Aaryan-Dadu Aaryan-Dadu changed the title fix test_convergence_plot_command_line [GSOC] fix test_convergence_plot_command_line Feb 16, 2026
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, works for me

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (8354e74).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Details
3	F811	[*] redefined-while-unused
1	I001	[*] unsorted-imports
Found 4 errors.
[*] 4 fixable with the `--fix` option.

Complete output(might be large):

Details
tardis/visualization/tools/tests/test_convergence_plot.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/tests/test_convergence_plot.py:14:25: F811 [*] Redefinition of unused `defaultdict` from line 3
tardis/visualization/tools/tests/test_convergence_plot.py:15:32: F811 [*] Redefinition of unused `go` from line 6
tardis/visualization/tools/tests/test_convergence_plot.py:16:30: F811 [*] Redefinition of unused `u` from line 8
Found 4 errors.
[*] 4 fixable with the `--fix` option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convergence plot test fails when run locally in VSCode

3 participants