Editorial: Remove unnecessary specification of supportedLocalesOf length properties#618
Merged
ryzokuken merged 1 commit intotc39:masterfrom Nov 8, 2021
Conversation
ryzokuken
approved these changes
Oct 25, 2021
Member
ryzokuken
left a comment
There was a problem hiding this comment.
Thanks, LGTM. What about the addition to conventions that you mention? Will you add another commit or should we go for a second PR?
Contributor
That's already part of https://tc39.es/ecma402/#requirements. |
Member
Author
|
Great! |
ljharb
approved these changes
Oct 25, 2021
Member
|
Looks like everything is in order, merging! Thanks @gibson042 @anba and @ljharb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some but not all
supportedLocalesOfdefinitions explicitly specifylength, but none of them should need to. However, we might consider updating https://tc39.es/ecma402/#conventions to explicitly adopt https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects