Editorial: Only set dtf.[[HourCycle]] once.#662
Merged
leobalter merged 4 commits intotc39:masterfrom Mar 28, 2022
Merged
Conversation
The field is set, read, and then immediately overwritten, without any other possible use in between.
ryzokuken
approved these changes
Mar 21, 2022
gibson042
requested changes
Mar 21, 2022
gibson042
approved these changes
Mar 23, 2022
Member
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
A few suggestions, but none of them necessary if you disagree.
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
leobalter
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field is set, read, and then immediately overwritten, without any other possible use in between.