Intl.DateTimeFormat should localize era names as well#89
Merged
caridy merged 1 commit intotc39:masterfrom Jun 9, 2016
Merged
Conversation
Contributor
|
LGTM. |
Member
|
Has anyone written test262 tests for this change? |
Contributor
|
I was planning to do so, or get @watilde (who has been very responsive to help). Additionally, we can get implementers to contribute back their existing tests since |
Contributor
Author
|
Wow, I should add the test case to test262 at the same time when I wrote this change. Sure thing, I will try to update the test case to cover this patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #88