Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2749 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 21 21
Lines 12444 12444
Branches 2255 2255
=======================================
Hits 12038 12038
Misses 349 349
Partials 57 57 ☔ View full report in Codecov by Sentry. |
ptomato
force-pushed
the
update-upstream-specs
branch
from
1c04683 to
f963825
Compare
Collaborator
Author
|
I've pushed an update to this - I originally forgot that the operations we shared with Intl.NumberFormat v3 and Intl enumeration are now part of ECMA-402, so those need to be updated and moved into ECMA-262 as well. |
ptomato
force-pushed
the
update-upstream-specs
branch
from
f963825 to
f635013
Compare
Brings in the upstream ECMA-262 text as of commit tc39/ecma262@7d26449.
ptomato
force-pushed
the
update-upstream-specs
branch
from
f635013 to
f3ed6b4
Compare
ben-allen
reviewed
Jan 26, 2024
Contributor
ben-allen
left a comment
ben-allen
left a comment
There was a problem hiding this comment.
This appears to me to be straightforwardly correct. My only suggestion is that there appear to be AOs with headers that explicitly list out the valid rounding mode strings rather than referring to the new Rounding modes table, and likely referring to the table is the right thing to do:
RoundTimeRoundISODateTimeTemporalZonedDateTimeToString
ben-allen
approved these changes
Jan 26, 2024
Brings in the upstream ECMA-402 text as of commit tc39/ecma402@537afda7, and adapts existing code on top of it. Notably, ECMA-402 has refactored so that InitializeDateTimeFormat is replaced by CreateDateTimeFormat, and ToDateTimeOptions is removed. This refactor changed the observable order of accessing the options passed to the Intl.DateTimeFormat constructors, in a way that was incompatible with changes that Temporal made to the same order of accessing. This commit reorders the new Temporal parts of CreateDateTimeFormat so that they no longer change the observable order of operations. The Temporal spec text had some overlap with operations from the Intl.NumberFormat v3 and Intl enumeration proposals. Now that these operations are part of ECMA-402, we also recommend moving them into ECMA-262 as part of the Temporal proposal. Also corrects some ECMA-402 "rebase errors" that inadvertently made normative changes in past updates. Closes: #1932 Closes: #2363 Closes: #2473
This adds structured headers to all the new abstract operations defined in spec/intl.html, and a Value Format Record type to describe the return value of the HandleDateTime___ operations.
ptomato
force-pushed
the
update-upstream-specs
branch
from
f3ed6b4 to
c87871d
Compare
Ms2ger
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This "rebases" Temporal on the most recent snapshots of ECMA-262 and ECMA-402, and adapts Temporal's modifications on top of them. It closes several open issues in this repo, including a few where previous "rebases" had caused unintended normative changes.
I would particularly appreciate extra review on the CreateDateTimeFormat part, because I wasn't very familiar with tc39/ecma402#709 which completely rewrote that section upstream.