Intl: Add coverage for meaningful @@toStringTag values#2634
Merged
leobalter merged 6 commits intotc39:masterfrom Jun 1, 2020
Merged
Intl: Add coverage for meaningful @@toStringTag values#2634leobalter merged 6 commits intotc39:masterfrom
leobalter merged 6 commits intotc39:masterfrom
Conversation
shvaikalesh
force-pushed
the
intl402-symbol-tostringtag
branch
from
93baee1 to
c84fed9
Compare
leobalter
suggested changes
May 21, 2020
Member
leobalter
left a comment
leobalter
left a comment
There was a problem hiding this comment.
LGTM, just one thing else I left in the comments for the coverage.
Let's wait until the PR is accepted before merging.
shvaikalesh
force-pushed
the
intl402-symbol-tostringtag
branch
from
c84fed9 to
74a7951
Compare
leobalter
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. tc39/ecma402#430