-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): Move to go modules; Upgrade distribution to latest version. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Move to go modules; Upgrade distribution to latest version. #2
Conversation
Cryptophobia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks real good and I would like to switch to go mods asap. Thanks @jfuechsl !
Makefile
Outdated
| endif | ||
|
|
||
| DEV_ENV_IMAGE := quay.io/deis/go-dev:0.11.1 | ||
| DEV_ENV_IMAGE := quay.io/deis/go-dev:v1.27.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change to use our own image here:
hephy/go-dev:v1.26.2
We are building it from here and merging upstream changes: https://github.com/teamhephy/docker-go-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this fix to use our own images @jfuechsl!
Cryptophobia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
Thanks! |
|
Good question @jfuechsl . That is done temporary because when we were making a new release the objstorage cli all of a sudden disappeared from the old deis' google storage link and I needed a quick fix. This is where it will reside in the future when we make a new version: For example we can make one that is always |
This PR contains the following changes: