Skip to content

Conversation

@jfuechsl
Copy link

This PR contains the following changes:

  1. Move to go modules (from glide).
  2. Update to the latest deis go base image.
  3. Upgrade the distribution dependency to the github.com/teamhephy/distribution fork

Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real good and I would like to switch to go mods asap. Thanks @jfuechsl !

Makefile Outdated
endif

DEV_ENV_IMAGE := quay.io/deis/go-dev:0.11.1
DEV_ENV_IMAGE := quay.io/deis/go-dev:v1.27.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change to use our own image here:

hephy/go-dev:v1.26.2

We are building it from here and merging upstream changes: https://github.com/teamhephy/docker-go-dev

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the change.

Copy link
Member

@Cryptophobia Cryptophobia Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this fix to use our own images @jfuechsl!

Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Cryptophobia Cryptophobia merged commit f5b0097 into teamhephy:master Jun 25, 2020
@jfuechsl
Copy link
Author

Thanks!
I see that the cli binary is checked in directly in repos that use it (https://github.com/teamhephy/slugbuilder/blob/master/rootfs/Dockerfile#L33) vs. hosting it somewhere. Will this stay that way? I'm preparing the PRs for the builders and runners.

@Cryptophobia
Copy link
Member

Good question @jfuechsl . That is done temporary because when we were making a new release the objstorage cli all of a sudden disappeared from the old deis' google storage link and I needed a quick fix.

This is where it will reside in the future when we make a new version:
https://storage.googleapis.com/hephy-obj-storage-cli/bb8e054/objstorage

For example we can make one that is always latest tag for the cli: https://storage.googleapis.com/hephy-obj-storage-cli/latest/objstorage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants