Skip to content

Add specification for tmt run policies#3771

Merged
psss merged 10 commits intomainfrom
run-profiles-into-spec
May 30, 2025
Merged

Add specification for tmt run policies#3771
psss merged 10 commits intomainfrom
run-profiles-into-spec

Conversation

@happz
Copy link
Copy Markdown
Contributor

@happz happz commented May 26, 2025

Part of #3538 and #3692.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • update the specification
  • include a release note

@happz happz added this to the 1.50 milestone May 26, 2025
@happz happz added the specification Metadata specification (core, tests, plans, stories) label May 26, 2025
@happz happz added this to planning May 26, 2025
@github-project-automation github-project-automation bot moved this to backlog in planning May 26, 2025
@happz happz moved this from backlog to review in planning May 26, 2025
graphite-app[bot]
graphite-app bot reviewed May 26, 2025
View reviewed changes
Comment thread spec/profiles.fmf Outdated
Comment thread spec/profiles.fmf Outdated
@happz happz mentioned this pull request May 26, 2025
Closed
martinhoyer
martinhoyer approved these changes May 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no "magic" operators for addition or merging provided by the

oh, nice. The whole think makes much more sense to me now.

Looking at long .fmf/.yml I always got reminded what a shame nobody cared about #2187

graphite-app[bot]
graphite-app bot reviewed May 26, 2025
View reviewed changes
Comment thread spec/profiles.fmf Outdated
psss
psss requested changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, just three minor suggestions.

Comment thread spec/profiles.fmf Outdated
Comment thread spec/profiles.fmf Outdated
@psss psss self-assigned this May 27, 2025
This was linked to issues May 27, 2025
Allow changing specific check if others have been configured by default #3611
Closed
Outline the default workflow configuration implementation #3692
Closed
lukaszachy
lukaszachy reviewed May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very easy to read and understand. The only piece I miss is at which time the template is processed (eg after fmf tree, adjust and CLI evaluation?)

psss
psss reviewed May 27, 2025
View reviewed changes
Comment thread spec/profiles.fmf Outdated
@happz happz force-pushed the run-profiles-into-spec branch from 5613b31 to a56c156 Compare May 27, 2025 09:13
@happz
Copy link
Copy Markdown
Contributor Author

happz commented May 27, 2025

Very easy to read and understand. The only piece I miss is at which time the template is processed (eg after fmf tree, adjust and CLI evaluation?)

Hopefuly addressed in a56c156.

graphite-app[bot]
graphite-app bot reviewed May 27, 2025
View reviewed changes
Comment thread spec/profiles.fmf Outdated
psss
psss approved these changes May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one idea, not crucial though.

Comment thread spec/profiles.fmf
@happz happz force-pushed the run-profiles-into-spec branch from 9236a16 to fb3fc27 Compare May 28, 2025 11:16
@happz happz mentioned this pull request May 29, 2025
Merged
4 tasks
@happz happz force-pushed the run-profiles-into-spec branch from fb3fc27 to bf8bd0e Compare May 29, 2025 09:43
@happz happz requested a review from psss May 29, 2025 09:44
@happz happz force-pushed the run-profiles-into-spec branch 2 times, most recently from 1ea96f2 to 38497c8 Compare May 29, 2025 15:04
@happz happz changed the title Add specification for tmt run profiles Add specification for tmt run policies May 29, 2025
graphite-app[bot]
graphite-app bot reviewed May 29, 2025
View reviewed changes
Comment thread spec/policies.fmf Outdated
martinhoyer
martinhoyer approved these changes May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread spec/policies.fmf Outdated
psss
psss requested changes May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two questions.

Comment thread docs/scripts/generate-stories.py Outdated
Comment thread spec/policies.fmf Outdated
@psss psss force-pushed the run-profiles-into-spec branch from 3ae9a89 to d1b6974 Compare May 30, 2025 07:58
@psss psss moved this from review to merge in planning May 30, 2025
@psss
Copy link
Copy Markdown
Member

psss commented May 30, 2025

Specification only, core test passed, merging.

@psss psss merged commit b4e05b4 into main May 30, 2025
13 of 21 checks passed
@psss psss deleted the run-profiles-into-spec branch May 30, 2025 08:53
@github-project-automation github-project-automation bot moved this from merge to done in planning May 30, 2025
tcornell-bus pushed a commit that referenced this pull request May 30, 2025
@happz @tcornell-bus
Add specification for tmt run policies (#3771)
8fd2bd8 
Part of #3538 and #3692.
bajertom pushed a commit that referenced this pull request Aug 11, 2025
@happz @bajertom
Add specification for tmt run policies (#3771)
08b49ac 
Part of #3538 and #3692.
@psss psss mentioned this pull request Sep 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@therazix therazix therazix approved these changes

+1 more reviewer

@martinhoyer martinhoyer martinhoyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@psss psss

Labels

specification Metadata specification (core, tests, plans, stories)

Projects

planning
Status: done

Milestone

1.50

Development

Successfully merging this pull request may close these issues.

Outline the default workflow configuration implementation Allow changing specific check if others have been configured by default

5 participants

@happz @psss @lukaszachy @martinhoyer @therazix