Skip to content

Encourage keeping the pull request description up-to-date#3865

Merged
psss merged 4 commits into
mainfrom
psss-pull-request-description
Jul 21, 2025
Merged

Encourage keeping the pull request description up-to-date#3865
psss merged 4 commits into
mainfrom
psss-pull-request-description

Conversation

@psss
Copy link
Copy Markdown
Member

@psss psss commented Jul 9, 2025

As agreed on the hacking session, we'll be using the pull request description content as the base for the squash commit to be merged into the main branch. Clearly encourage contributors to keep the pull request description up-to-date. Reorder the section a bit to align the steps with the order in which they are performed. Update the merging instructions as well. Improve the wording a bit, update label names.

Pull Request Checklist

  • write the documentation

Comment thread docs/contribute.rst Outdated
@psss psss added the documentation Improvements or additions to documentation label Jul 9, 2025
@psss psss added this to planning Jul 9, 2025
@github-project-automation github-project-automation Bot moved this to backlog in planning Jul 9, 2025
Comment thread docs/contribute.rst Outdated
@psss psss moved this from backlog to review in planning Jul 9, 2025
@psss psss requested review from therazix and vaibhavdaren July 16, 2025 13:45
Copy link
Copy Markdown
Contributor

@vaibhavdaren vaibhavdaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss psss added this to the 1.54 milestone Jul 17, 2025
@happz happz moved this from review to merge in planning Jul 18, 2025
@psss psss requested a review from AthreyVinay July 18, 2025 09:05
@psss psss added the area | contribute Improving experience for tmt contributors label Jul 18, 2025
@happz happz force-pushed the psss-pull-request-description branch from f65d813 to 50e1937 Compare July 18, 2025 13:19
Comment thread docs/contribute.rst Outdated
psss and others added 3 commits July 21, 2025 15:42
As agreed on the hacking session, we'll be using the pull request
description content as the base for the squash commit to be merged into
the `main` branch. Clearly encourage contributors to keep the pull
request description up-to-date. Reorder the section a bit to align the
steps with the order in which they are performed. Update the merging
instructions as well. Improve the wording a bit, update label names.
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@psss psss force-pushed the psss-pull-request-description branch from 50e1937 to 0b8b35c Compare July 21, 2025 13:48
@psss psss force-pushed the psss-pull-request-description branch from 0b8b35c to b5e533f Compare July 21, 2025 13:58
@psss psss requested a review from happz July 21, 2025 14:00
@psss psss merged commit 63d0497 into main Jul 21, 2025
11 of 18 checks passed
@psss psss deleted the psss-pull-request-description branch July 21, 2025 15:14
@github-project-automation github-project-automation Bot moved this from merge to done in planning Jul 21, 2025
@psss psss self-assigned this Jul 21, 2025
bajertom pushed a commit that referenced this pull request Aug 11, 2025
As agreed on the hacking session, we'll be using the pull request
description content as the base for the squash commit to be merged into
the `main` branch. Clearly encourage contributors to keep the pull
request description up-to-date. Reorder the section a bit to align the
steps with the order in which they are performed. Update the merging
instructions as well. Improve the wording a bit, update label names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area | contribute Improving experience for tmt contributors documentation Improvements or additions to documentation

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

5 participants