Skip to content

Make mypy and pyright pre-commit satisifed#3901

Merged
psss merged 1 commit into
mainfrom
avinay-pre-commit-mypy
Jul 22, 2025
Merged

Make mypy and pyright pre-commit satisifed#3901
psss merged 1 commit into
mainfrom
avinay-pre-commit-mypy

Conversation

@AthreyVinay
Copy link
Copy Markdown
Member

Fixes issue while pre-commit checks are made.

@AthreyVinay AthreyVinay requested a review from happz July 21, 2025 15:09
@happz happz added this to planning Jul 21, 2025
@github-project-automation github-project-automation Bot moved this to backlog in planning Jul 21, 2025
@happz happz moved this from backlog to review in planning Jul 21, 2025
Copy link
Copy Markdown
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes the mypy error.

@psss psss changed the title mypy and pyright pre-commit satisifed Make mypy and pyright pre-commit satisifed Jul 21, 2025
@psss
Copy link
Copy Markdown
Member

psss commented Jul 21, 2025

Hmmm, pull request pre-commit is not happy:

tmt/utils/rest.py:434: error: Unused "type: ignore" comment  [unused-ignore]

@psss
Copy link
Copy Markdown
Member

psss commented Jul 21, 2025

Seemed to be caused by an outdated cache:

Cleared and now it's green! \o/

@psss psss added this to the 1.54 milestone Jul 21, 2025
@psss psss added code | type annotations Related to type annotations and type cleanup test coverage Improvements or additions to test coverage of tmt itself labels Jul 21, 2025
@happz happz added the ci | full test Pull request is ready for the full test execution label Jul 21, 2025
@happz happz force-pushed the avinay-pre-commit-mypy branch from 4617370 to ba34db1 Compare July 21, 2025 17:34
@happz happz moved this from review to merge in planning Jul 21, 2025
@happz happz force-pushed the avinay-pre-commit-mypy branch from ba34db1 to 0ec635e Compare July 21, 2025 17:52
@psss psss merged commit b31761a into main Jul 22, 2025
17 checks passed
@psss psss deleted the avinay-pre-commit-mypy branch July 22, 2025 06:44
@github-project-automation github-project-automation Bot moved this from merge to done in planning Jul 22, 2025
@psss psss self-assigned this Jul 22, 2025
bajertom pushed a commit that referenced this pull request Aug 11, 2025
Fixes issue while pre-commit checks are made.

Co-authored-by: AthreyVinay <avinay@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution code | type annotations Related to type annotations and type cleanup test coverage Improvements or additions to test coverage of tmt itself

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

3 participants