Skip to content

Add the new cleanup step to tmt try as well#3933

Merged
psss merged 1 commit into
mainfrom
psss-tmt-try-cleanup
Jul 30, 2025
Merged

Add the new cleanup step to tmt try as well#3933
psss merged 1 commit into
mainfrom
psss-tmt-try-cleanup

Conversation

@psss
Copy link
Copy Markdown
Member

@psss psss commented Jul 30, 2025

The tmt try command needs to be updated as well to include the new cleanup command. Without this change provisioned guests would not be stopped and removed upon quit from the tmt try session.

Related: #3904

Pull Request Checklist

  • implement the feature
  • extend the test coverage

The `tmt try` command needs to be updated as well to include the new
`cleanup` command. Without this change provisioned guests would not be
stopped and removed upon quit from the `tmt try` session.

Related: #3904
@psss psss requested a review from falconizmi as a code owner July 30, 2025 13:16
@psss psss added command | try tmt try command step | cleanup Stuff related to the cleanup step labels Jul 30, 2025
@psss psss added this to planning Jul 30, 2025
@github-project-automation github-project-automation Bot moved this to backlog in planning Jul 30, 2025
@psss psss added this to the 1.54 milestone Jul 30, 2025
@psss psss moved this from backlog to review in planning Jul 30, 2025
@psss psss added the ci | full test Pull request is ready for the full test execution label Jul 30, 2025
@happz happz moved this from review to merge in planning Jul 30, 2025
@psss
Copy link
Copy Markdown
Member Author

psss commented Jul 30, 2025

Thanks much for the fast review! 👍

@psss psss self-assigned this Jul 30, 2025
@psss psss merged commit 8076f74 into main Jul 30, 2025
17 of 18 checks passed
@psss psss deleted the psss-tmt-try-cleanup branch July 30, 2025 17:14
@github-project-automation github-project-automation Bot moved this from merge to done in planning Jul 30, 2025
bajertom pushed a commit that referenced this pull request Aug 11, 2025
The `tmt try` command needs to be updated as well to include the new
`cleanup` command. Without this change provisioned guests would not be
stopped and removed upon quit from the `tmt try` session.

Related: #3904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution command | try tmt try command step | cleanup Stuff related to the cleanup step

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

5 participants