Make use of makes implicit variables#23
Merged
telatin merged 2 commits intotelatin:mainfrom Apr 16, 2024
martin-g:better-makefile
Merged
Make use of makes implicit variables#23telatin merged 2 commits intotelatin:mainfrom martin-g:better-makefile
makes implicit variables#23telatin merged 2 commits intotelatin:mainfrom
martin-g:better-makefile
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Owner
|
Thanks a million! Will look into it ASAP |
telatin
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
This makes is easier for the user to overwrite the compiler, e.g. to use Clang, and the compiler and linker flags.
Without such improvement I needed to use
sedto addLDFLAGSsupport for the Bioconda build - bioconda/bioconda-recipes#47230Also added a new Github Actions workflow that shows usage of
makeand demoes overwriting of the implicit variables.