-
Notifications
You must be signed in to change notification settings - Fork 433
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Bug
Running the helm template command with helm v2 can result in whitespace being removed, invalidating the helm chart.
The output of range templates inserver-service.yaml and server-deployment.yaml results in:
---apiVersion: v1
kind: Service
instead of
---
apiVersion: v1
kind: Service
See this issue with Cadence template for more detail: helm/helm#7149
To Reproduce
- Using any helm 2.x
- Run helm template
Expected behavior
Helm should not strip whitespace.
Versions (please complete the following information where relevant):
- OS: mac
- Temporal Version 1.9.2
- using Kubernetes and helm v2
Additional context
I think this could be fixed by changing:
{{- range $service := (list "frontend" "history" "matching" "worker") }}
{{- $serviceValues := index $.Values.server $service -}}
to
{{- range $service := (list "frontend" "history" "matching" "worker") }}
{{- $serviceValues := index $.Values.server $service }}
which will not remove whitespace.
I'm not sure if this will have any unintended impact
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
