fix: disable default features for prometheus dependency#1134
Merged
Sushisource merged 3 commits intotemporalio:masterfrom Mar 9, 2026
Merged
fix: disable default features for prometheus dependency#1134Sushisource merged 3 commits intotemporalio:masterfrom
Sushisource merged 3 commits intotemporalio:masterfrom
Conversation
temporalio-common currently imports prometheus with default features enabled. The prometheus crate includes protobuf by default, which temporalio-common does not use. This disables default features for the prometheus dependency to avoid pulling in the unnecessary protobuf transitive dependency.
|
|
Sushisource
approved these changes
Mar 9, 2026
This was referenced Mar 19, 2026
Closed
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team,
for internal use at Cloudflare we have applied this patch to the
temporalio-commoncrate. I think this could be useful to add to the main repo as well.What was changed
This patch disables default features for the
prometheusdependency to avoid pulling in theprotobuftransitive dependency.Why?
The
temporalio-commoncrate importsprometheusas dep with default features enabled since c781a61.The
prometheuscrate by default includesprotobuf, whichtemporalio-commondoes not use.