💥 [BREAKING CHANGE] Rename Nexus Operation classes used in a workflow in preparation for Stand alone Nexus operations#619
Merged
Quinn-With-Two-Ns merged 5 commits intotemporalio:mainfrom Mar 10, 2026
Conversation
jmaeagle99
approved these changes
Feb 26, 2026
cretz
reviewed
Feb 27, 2026
| /// <remarks>WARNING: Nexus support is experimental.</remarks> | ||
| public static NexusClient CreateNexusClient(string service, string endpoint) => | ||
| CreateNexusClient(service, new NexusClientOptions(endpoint)); | ||
| public static NexusWorkflowClient CreateNexusWorkflowClient(string service, string endpoint) => |
Contributor
There was a problem hiding this comment.
Arguably the method name here (and in interceptors) should stay the same. It is clearly in the workflow class, there is no ambiguity, and there is not much value in qualifying the method name. (of course return type being NexusWorkflowClient makes sense)
Contributor
Author
There was a problem hiding this comment.
I think it'd be odd for the method names to not match the type returned, but i'll defer to you and Justin
Contributor
There was a problem hiding this comment.
I agree with Quinn on this. And it leaves room in the future if we need to return some other type of Nexus client that isn't a NexusWorkflowClient.
Quinn-With-Two-Ns
changed the title
This was referenced Mar 19, 2026
Closed
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Nexus Operation classes used in a workflow. I went with inserting
Workflowinto the name, but am open to other suggestions.closes #618
Note
Medium Risk
Breaking public API rename across workflow Nexus client/handle/options and related interceptor signatures; functional behavior appears unchanged but downstream projects will require code updates and any missed rename could surface as runtime/compile failures.
Overview
Renames the workflow-scoped Nexus API surface to explicitly include
Workflowin the type names, updatingWorkflow.CreateNexusClienttoWorkflow.CreateNexusWorkflowClientand renamingNexusClient*,NexusOperationHandle*, and related options toNexusWorkflowClient*,NexusWorkflowOperationHandle*, andNexusWorkflow*Options.Updates all internal plumbing and interception points (workflow outbound interceptors, OpenTelemetry
TracingInterceptor, andWorkflowInstanceimplementations) plus tests and README references to use the new names.Written by Cursor Bugbot for commit e01b7bd. This will update automatically on new commits. Configure here.