Merged
Conversation
THardy98
changed the title
mjameswh
reviewed
Dec 2, 2025
| return typeof tls === 'object' ? (tls === null ? undefined : tls) : tls ? {} : undefined; | ||
| } | ||
|
|
||
| export function defaultTLSFromApiKey( |
Contributor
There was a problem hiding this comment.
Why introduce a new function for this? Can't we simply pass a second argument to normalizeTlsConfig?
mjameswh
reviewed
Dec 2, 2025
Contributor
mjameswh
left a comment
mjameswh
left a comment
There was a problem hiding this comment.
You missed a call to normalizeTlsConfig() in cloud-operations-client.ts.
THardy98
force-pushed
the
enable-tls-if-apikey
branch
from
c160b48 to
3585a46
Compare
mjameswh
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT
Part of Assume TLS enabled if API key provided in SDKs features#687
How was this tested:
Unit tests
Any docs updates needed?
Maybe?