fix(ai): Add await to tool execution#1882
Merged
chris-olszewski merged 2 commits intomainfrom Jan 12, 2026
Merged
Conversation
Add a test that verifies the MCP client close() method is called after tool.execute() completes, not before. This test currently fails because callToolActivity is missing an await keyword. Reproduces #1881 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add missing await before tool.execute() call in callToolActivity. Without this await, the finally block would close the MCP client connection before the tool execution completed, causing the connection to be terminated prematurely. Fixes #1881 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mjameswh
approved these changes
Jan 12, 2026
tconley1428
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add missing
awaitcall toexecuteToolActivityWhy?
closewould end up getting called before tool execution would be completedChecklist
Closes [Bug] AI-SDK - callToolActivity #1881
How was this tested:
Added failing test in first commit that verifies
closeis called after the activity completes.Any docs updates needed?
N/A