[Blocked on all other GA PRs, will go last] CRD Rename#294
Draft
carlydf wants to merge 6 commits intocrd-renamefrom
Draft
[Blocked on all other GA PRs, will go last] CRD Rename#294carlydf wants to merge 6 commits intocrd-renamefrom
carlydf wants to merge 6 commits intocrd-renamefrom
Conversation
…Connection Primary CRD types drop the redundant Temporal prefix. Deprecated stubs (TemporalWorkerDeployment, TemporalConnection) are kept as minimal structs with CEL create-rejection to block new creates during the migration window. Key changes: - api/v1alpha1: rename primary types, move deprecated stubs to separate files, add WRT dual-field (workerDeploymentRef + temporalWorkerDeploymentRef) with EffectiveWorkerDeploymentName() resolver, update zz_generated.deepcopy.go - workerdeployment_webhook.go: renamed from temporalworker_webhook.go, paths updated to /mutate|validate-temporal-io-v1alpha1-workerdeployment - internal/controller: rename reconciler struct/fields; add DeprecatedTWDReconciler (sets Ready=False with one of three reasons; never touches Temporal APIs); add migrateFromDeprecatedTWD() that patches Deployment and WRT ownerRefs from deprecated TWD UID to new WD UID, then labels the TWD as migrated - internal/k8s, planner, temporal, defaults: update all type references Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… update RBAC/webhook CRD chart (temporal-worker-controller-crds): - Add temporal.io_workerdeployments.yaml and temporal.io_connections.yaml (full schemas, short names: wd/wdeployment and conn) - Simplify deprecated temporal.io_temporalworkerdeployments.yaml and temporal.io_temporalconnections.yaml: minimal spec schema with x-kubernetes-preserve-unknown-fields, CEL rule (oldSelf != null) to reject new creates while allowing updates/deletes - Update temporal.io_workerresourcetemplates.yaml: add workerDeploymentRef field alongside temporalWorkerDeploymentRef (dual-field migration support) - Archive original full-schema deprecated CRDs to deprecated/ for reference - Bump chart version to 0.25.0 Controller chart (temporal-worker-controller): - rbac.yaml: add manager ClusterRole rules for workerdeployments/connections primary resources; add workerdeployment-editor/viewer and connection- editor/viewer ClusterRoles; keep deprecated temporalworkerdeployment and temporalconnection roles for migration window; fix temporal.io.temporal.io apiGroup typo in old editor/viewer roles - webhook.yaml: replace old twd-validating-webhook with wd-mutating-webhook and wd-validating-webhook pointing at updated /workerdeployment paths - Bump chart version to 0.25.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Renamed/deleted: - temporalworker_webhook_test.go → workerdeployment_webhook_test.go - temporalworkerdeployment_cel_validation_test.go → workerdeployment_cel_validation_test.go Updated throughout: type references (TWD→WorkerDeployment, TC→Connection), makeTWD helpers, kind strings, field names. New in deprecated_reconciler_test.go: - DeprecatedTWDReconciler: three condition-state unit tests (Deprecated, WorkerDeploymentExists, MigratedToWorkerDeployment) + not-found no-op - migrateFromDeprecatedTWD: transfers Deployment and WRT ownerRefs from deprecated TWD UID to new WD UID; skips if already migrated; leaves unrelated Deployments untouched New in workerresourcetemplate_webhook_test.go: - Deprecated temporalWorkerDeploymentRef emits a deprecation warning - Both refs set → rejected - Neither ref set → rejected - Immutability enforced across all ref-field combinations including deprecated→new field switching with same/different effective names Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
TemporalConnectionSpec → ConnectionSpec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
carlydf
commented
Apr 24, 2026
| //+kubebuilder:object:root=true | ||
| //+kubebuilder:subresource:status | ||
| //+kubebuilder:resource:shortName=tconn | ||
| //+kubebuilder:resource:shortName=conn |
Collaborator
Author
There was a problem hiding this comment.
can we / should we keep tconn?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Not ready for review :)
Why?
Checklist
Closes
How was this tested: