[Bug]: `-D` argument to `build-package.sh` does not work

[robertkirkman]

Problem description

This is an issue for tracking progress on the ability to build packages that are in the disabled-packages folder by using the -D argument rather than manually moving them out of that folder.

I sometimes build disabled-packages, but I had been in the habit of always temporarily moving them to the packages folder when I need them and then moving them back when I am done with them, because I believe there are multiple inconvenient problems that can happen when attempting to use the -D argument.

What steps will reproduce the bug?

git clone https://github.com/termux/termux-packages.git
cd termux-packages
scripts/run-docker.sh ./build-package.sh -I -f -D news-flash-gtk

The first error that happens is this,

ERROR: Duplicated package: python-tkinter
ERROR: Obtaining buildorder failed

then, if these commands are used to temporarily work around that,

rm -rf disabled-packages/python3.11/
scripts/run-docker.sh ./build-package.sh -I -f -D news-flash-gtk

this happens instead,

ERROR: Package midori depends on non-existing package "webkit2gtk"
ERROR: Obtaining buildorder failed

and then if these commands are used to temporarily work around that,

rm -rf disabled-packages/midori/
scripts/run-docker.sh ./build-package.sh -I -f -D news-flash-gtk

this error happens instead:

ERROR: Package neovim-nightly depends on non-existing package "libtreesitter"
ERROR: Obtaining buildorder failed

and so on, more errors keep happening, so it appears that the -D argument does not currently work.

What is the expected behavior?

Being able to build packages that are in the disabled-packages folder without moving them out of that folder

System information

N/A

[agnostic-apollo]

Ah, dependency issues would be expected as disabled packages would only be buildable at the commit point they were removed, they aren't maintained afterwards.

The duplicate package issue could be solvable by not using packages from disabled directories if same package exists in the enabled directories. Non existent packages wouldn't be fixable by build order script, that would probably require fixing build.sh or re-adding removed packages to disabled packages.

These issues aren't fixed by my repo.json and bootstrap pulls currently, so no need to test.

[truboxl]

Can add CI to check but I really dont think its worth the effort