Skip to content

Conversation

@bendrucker
Copy link
Member

@bendrucker bendrucker commented Oct 30, 2025

Fixes inconsistent ordering of rulesets in tflint --version output. Previously, rulesets were iterated in random order (as a map) which caused the output of tflint --version to be non-deterministic.

Changes

  • Sort ruleset names alphabetically before displaying using slices.Sorted(maps.Keys())
  • Add integration test to verify alphabetical ordering

References

Closes #2403

Fixes #2403

Sort rulesets alphabetically when displaying version information to
ensure consistent output across multiple runs. Previously, rulesets
appeared in non-deterministic order due to Go map iteration randomization.

Changes:
- Sort ruleset names before iterating in getPluginVersions()
- Add integration test to verify consistent alphabetical ordering
@bendrucker bendrucker changed the title fix: sort rulesets alphabetically in version output Alphabetize rulesets in version output Oct 30, 2025
@bendrucker bendrucker merged commit 56b6432 into master Oct 30, 2025
19 checks passed
@bendrucker bendrucker deleted the fix-version-ordering branch October 30, 2025 04:30
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 21, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [tflint](https://github.com/terraform-linters/tflint) | minor | `0.59.1` -> `0.60.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>terraform-linters/tflint (tflint)</summary>

### [`v0.60.0`](https://github.com/terraform-linters/tflint/releases/tag/v0.60.0)

[Compare Source](terraform-linters/tflint@v0.59.1...v0.60.0)

#### What's Changed

This release introduces a new configuration file format: `.tflint.json`. This is useful for workflows such as automatically generating configuration files.
Please note that in order to use the `.tflint.json`, enabled plugins must be built with SDK v0.23+.

From this release, Cosign signatures (`checksums.txt.keyless.sig` and `checksums.txt.pem`) are deprecated. They will not be included in future releases. If your installation scripts depend on them, please migrate to `gh attestation verify`.

##### Enhancements

- Add JSON configuration file support by [@&#8203;rorychatterton](https://github.com/rorychatterton) in [#&#8203;2391](terraform-linters/tflint#2391)
- Report structured errors in JUnit and CheckStyle XML formatters by [@&#8203;bendrucker](https://github.com/bendrucker) in [#&#8203;2407](terraform-linters/tflint#2407)

##### Changes

- Alphabetize rulesets in version output by [@&#8203;bendrucker](https://github.com/bendrucker) in [#&#8203;2404](terraform-linters/tflint#2404)
- release: Pin Cosign version and deprecate Cosign signatures by [@&#8203;wata727](https://github.com/wata727) in [#&#8203;2405](terraform-linters/tflint#2405)

##### Bug Fixes

- fix: only read TF\_VAR for root module by [@&#8203;bendrucker](https://github.com/bendrucker) in [#&#8203;2413](terraform-linters/tflint#2413)

##### Chores

- build(deps): Bump actions/attest-build-provenance from 2.4.0 to 3.0.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2376](terraform-linters/tflint#2376)
- build(deps): Bump actions/setup-go from 5.5.0 to 6.0.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2377](terraform-linters/tflint#2377)
- build(deps): Bump the go-x group with 3 updates by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2378](terraform-linters/tflint#2378)
- build(deps): Bump github.com/spf13/afero from 1.14.0 to 1.15.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2380](terraform-linters/tflint#2380)
- build(deps): Bump github.com/zclconf/go-cty from 1.16.4 to 1.17.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2379](terraform-linters/tflint#2379)
- build(deps): Bump golang.org/x/net from 0.43.0 to 0.44.0 in the go-x group by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2381](terraform-linters/tflint#2381)
- build(deps): Bump google.golang.org/grpc from 1.75.0 to 1.75.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2382](terraform-linters/tflint#2382)
- build(deps): Bump github.com/sigstore/sigstore-go from 1.1.1 to 1.1.2 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2383](terraform-linters/tflint#2383)
- build(deps): Bump sigstore/cosign-installer from 3.9.2 to 3.10.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2384](terraform-linters/tflint#2384)
- build(deps): Bump mislav/bump-homebrew-formula-action from 3.5 to 3.6 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2388](terraform-linters/tflint#2388)
- fix(script): GitHub API rate limit by [@&#8203;Sander0542](https://github.com/Sander0542) in [#&#8203;2390](terraform-linters/tflint#2390)
- Bump tflint-plugin-sdk to v0.23.0 by [@&#8203;wata727](https://github.com/wata727) in [#&#8203;2393](terraform-linters/tflint#2393)
- build(deps): Bump github.com/sigstore/sigstore-go from 1.1.2 to 1.1.3 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2394](terraform-linters/tflint#2394)
- build(deps): Bump docker/login-action from 3.5.0 to 3.6.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2395](terraform-linters/tflint#2395)
- build(deps): Bump the go-x group with 4 updates by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2397](terraform-linters/tflint#2397)
- build(deps): Bump google.golang.org/grpc from 1.75.1 to 1.76.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2398](terraform-linters/tflint#2398)
- build(deps): Bump sigstore/cosign-installer from 3.10.0 to 4.0.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2399](terraform-linters/tflint#2399)
- build(deps): Bump golang.org/x/net from 0.45.0 to 0.46.0 in the go-x group by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2400](terraform-linters/tflint#2400)
- build(deps): Bump github.com/terraform-linters/tflint-plugin-sdk from 0.23.0 to 0.23.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2402](terraform-linters/tflint#2402)
- build(deps): Bump golangci/golangci-lint-action from 8.0.0 to 9.0.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2408](terraform-linters/tflint#2408)
- build(deps): Bump docker/metadata-action from 5.8.0 to 5.9.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2409](terraform-linters/tflint#2409)
- build(deps): Bump golang.org/x/oauth2 from 0.32.0 to 0.33.0 in the go-x group by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2410](terraform-linters/tflint#2410)

#### New Contributors

- [@&#8203;Sander0542](https://github.com/Sander0542) made their first contribution in [#&#8203;2390](terraform-linters/tflint#2390)
- [@&#8203;rorychatterton](https://github.com/rorychatterton) made their first contribution in [#&#8203;2391](terraform-linters/tflint#2391)

**Full Changelog**: <terraform-linters/tflint@v0.59.1...v0.60.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent order of rulesets when asked via tflint --version

2 participants