Skip to content

chore: Remove Git LFS tracking for .snk#1655

Merged
HofmeisterAn merged 1 commit intodevelopfrom
bugfix/remove-snk-from-git-lfs
Mar 7, 2026
Merged

chore: Remove Git LFS tracking for .snk#1655
HofmeisterAn merged 1 commit intodevelopfrom
bugfix/remove-snk-from-git-lfs

Conversation

@HofmeisterAn
Copy link
Collaborator

@HofmeisterAn HofmeisterAn commented Mar 7, 2026

What does this PR do?

The Dependabot GH Actions workflow does not check out files tracked by Git LFS, which causes the workflow to fail. This PR removes the .snk file from Git LFS tracking.

Why is it important?

-

Related issues

-

Summary by CodeRabbit

  • Chores

    • Removed Git LFS handling for specific binary file types.
    • Added workflow configuration file reference to solution projects.
  • Refactor

    • Reordered health-check configuration method calls to maintain equivalent functionality.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Mar 7, 2026
@netlify
Copy link

netlify bot commented Mar 7, 2026

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 21024aa
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/69ac5d49e68bc00008f4ef4f
😎 Deploy Preview https://deploy-preview-1655--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9a8732fb-7105-40ed-8c21-a0c2a2a65bc1

📥 Commits

Reviewing files that changed from the base of the PR and between 70ea93f and 21024aa.

📒 Files selected for processing (5)
  • .gitattributes
  • Testcontainers.sln
  • Testcontainers.slnx
  • src/Testcontainers.Typesense/TypesenseBuilder.cs
  • src/strongname.snk
💤 Files with no reviewable changes (1)
  • .gitattributes

Walkthrough

The PR makes minor configuration updates: removes SNK Git LFS tracking, adds a scorecard workflow reference to solution files, and reorders method calls in the Typesense health-check configuration without altering functionality.

Changes

Cohort / File(s) Summary
Git Configuration
.gitattributes
Removed Git LFS handling for .snk files, retaining other LFS rules.
Solution Files
Testcontainers.sln, Testcontainers.slnx
Added references to .github/workflows/scorecard-analysis.yml workflow file in solution items.
Typesense Health Check
src/Testcontainers.Typesense/TypesenseBuilder.cs
Reordered fluent method calls: swapped ForPath/ForPort sequence in health-check wait strategy initialization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • feat: Add SLNX file #1579: Both PRs modify the solution descriptor file Testcontainers.slnx (the main PR adds a workflow file reference; the retrieved PR introduced the .slnx file).

Poem

🐰 A workflow hops into sight,
Git rules trimmed nice and tight,
Method calls dance in a new light,
All configs set just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately describes the primary change: removing Git LFS tracking for .snk files, which is the most significant functional change in the PR.
Description check ✅ Passed The description includes the mandatory 'What does this PR do?' and 'Why is it important?' sections, though the latter is marked with just a dash. The core rationale (Dependabot workflow failure) is clearly explained.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/remove-snk-from-git-lfs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HofmeisterAn HofmeisterAn merged commit 84f4f7c into develop Mar 7, 2026
16 checks passed
@HofmeisterAn HofmeisterAn deleted the bugfix/remove-snk-from-git-lfs branch March 7, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant