feat: add basic browser support #26
Merged
laurentsenta merged 13 commits intotestground:masterfrom Nov 16, 2022
Merged
Conversation
Contributor
|
cc @achingbrain if you want to take a look |
Contributor
Author
|
@laurentsenta this one is ready for a re-review! All checks pass now and comments have been applied. |
3 tasks
Contributor
Author
|
Added functionality to be able to move args from host Env to Browser Env, without having to expose the required keys explicitly: 06df3ce (required for: testground/testground#1502 (comment)) |
added 3 commits
November 12, 2022 15:25
this way browser can wait for it, given it lives in a different process than the main driver
- logger needs to handle winston-like usage, making sure we log everything nicely as-is, instead of passing it directly we first need to manipualte it in a winston like manner to get a good effect - process was used in sync, but we cannot use this, env extraction is now cross-inner-package - this comples the env usage for node-browser-crossing
12 tasks
Contributor
Author
|
You can see this version of |
laurentsenta
requested changes
Nov 14, 2022
Contributor
There was a problem hiding this comment.
Thanks for recreating the PR, it looks great now, two last questions before we can merge:
- Could we keep the TODO comments if they were not introduced in this PR? I don't have context on these.
- Could we go back to the initial logging approach? I'd rather keep it simple & use the code before implementing optimizations, json outputs, etc. That might be related to testground/testground#1355 (comment)
Contributor
Author
|
laurentsenta
approved these changes
Nov 16, 2022
laurentsenta
changed the title
Contributor
|
(updated description and title and merging, thanks for the PR!) |
Member
|
Congratulations @GlenDC and @laurentsenta for this milestone! |
|
Agreed - way to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browserfield to supportregisterTestcaseResultto communicate end of test with a node runner when running in-browsergetEnvParametersto let a client gather and move testground variables (used for browser support).Supersede #25, having applies all the previous feedback.