Skip to content

feat(base-cluster/monitoring): configure service graph for grafana#1422

Merged
cwrau merged 1 commit intomainfrom
feat/base-cluster/configure-service-graph
Jun 6, 2025
Merged

feat(base-cluster/monitoring): configure service graph for grafana#1422
cwrau merged 1 commit intomainfrom
feat/base-cluster/configure-service-graph

Conversation

@cwrau
Copy link
Member

@cwrau cwrau commented Mar 24, 2025

This enables nice graphs like;

image

Summary by CodeRabbit

  • New Features

    • Enhanced monitoring and tracing integrations, including new remote write capabilities and additional metric exporters.
    • Introduced improved service traffic management for internal connectivity.
  • Bug Fixes

    • Updated telemetry configurations to ensure port values are correctly formatted and cast, reducing potential misinterpretation issues.

@cwrau cwrau enabled auto-merge (squash) March 24, 2025 11:07
@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2025

Warning

Rate limit exceeded

@cwrau has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 85f7950 and 8aa9b91.

📒 Files selected for processing (4)
  • charts/base-cluster/templates/descheduler/descheduler.yaml (1 hunks)
  • charts/base-cluster/templates/kyverno/kyverno.yaml (1 hunks)
  • charts/base-cluster/templates/monitoring/alloy.yaml (3 hunks)
  • charts/base-cluster/templates/monitoring/kube-prometheus-stack/_prometheus_config.yaml (2 hunks)

Walkthrough

The changes update YAML configurations across multiple files to enhance telemetry and monitoring setups. In several files, the port number is explicitly cast to an int64 and the formatted output is quoted to ensure proper type handling. In addition, new monitoring components are introduced in one configuration file, including Prometheus remote write settings, OTEL exporter/connector definitions, updated batching inputs, and a service configuration setting the internal traffic policy to Local.

Changes

File(s) Change Summary
charts/base-cluster/templates/descheduler/descheduler.yaml, charts/base-cluster/templates/kyverno/kyverno.yaml, charts/base-cluster/templates/monitoring/kube-prometheus-stack/_prometheus_config.yaml Updated telemetry formatting: port numbers are explicitly converted to int64 and the output is quoted. The Prometheus config additionally enables the remote write receiver via enableRemoteWriteReceiver: true.
charts/base-cluster/templates/monitoring/alloy.yaml Added new monitoring and tracing configurations including a Prometheus remote_write block, an OTEL Prometheus exporter, a service graph connector, an updated OTEL batch processor input, and a service configuration with internalTrafficPolicy: Local.

Sequence Diagram(s)

sequenceDiagram
    participant PromRW as Prometheus Remote Write
    participant Exporter as OTEL Prometheus Exporter
    participant Connector as Service Graph Connector
    participant Processor as OTEL Batch Processor

    PromRW->>Exporter: Forward metrics
    Exporter->>Connector: Pass metrics with dimensions
    Connector->>Processor: Supply consolidated metric input
    Processor->>System: Process and batch metrics
Loading

Suggested reviewers

  • teutonet-bot
  • marvinWolff
  • tasches

Poem

I'm a bunny with a clever beat,
Watching configs hop into a neat feat.
Ports are cast and strings are quoted,
New metrics flow like dreams noted.
With Prometheus and OTEL in the dance,
I bounce with joy at this upgrade chance!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cwrau cwrau force-pushed the feat/base-cluster/configure-service-graph branch 5 times, most recently from 3dd7313 to 216a9a0 Compare April 28, 2025 14:06
@cwrau cwrau force-pushed the feat/base-cluster/configure-service-graph branch from 216a9a0 to 8aa9b91 Compare June 5, 2025 08:35
@cwrau cwrau disabled auto-merge June 6, 2025 09:25
@cwrau cwrau added this pull request to the merge queue Jun 6, 2025
Merged via the queue into main with commit 8d4bb4c Jun 6, 2025
27 checks passed
@cwrau cwrau deleted the feat/base-cluster/configure-service-graph branch June 6, 2025 09:26
github-merge-queue bot pushed a commit that referenced this pull request Jun 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[8.1.0](base-cluster-v8.0.0...base-cluster-v8.1.0)
(2025-06-06)


### Features

* **base-cluster/monitoring:** allow upsizing tempo storage
([#1448](#1448))
([db1a742](db1a742))
* **base-cluster/monitoring:** also read secrets for datasources
([#1479](#1479))
([83ba8bd](83ba8bd))
* **base-cluster/monitoring:** configure service graph for grafana
([#1422](#1422))
([8d4bb4c](8d4bb4c))
* **base-cluster/monitoring:** set code challenge for grafana
([#1500](#1500))
([aa803da](aa803da))
* **base-cluster/monitoring:** set code_challenge_method for
oauth2-proxy
([#1496](#1496))
([b252cd7](b252cd7))


### Bug Fixes

* **base-cluster:** this prevents the user from installing this under
another name
([#1418](#1418))
([f4807e8](f4807e8))


### Miscellaneous Chores

* **base-cluster/docs:** update flux helmrelease command to update CRDs
([#1421](#1421))
([a8fd535](a8fd535))
* **base-cluster/monitoring:** remove unnecessary
open-telemetry-collector dashboard
([#1449](#1449))
([520e9e1](520e9e1))
* **base-cluster:** change descheduler syntax
([#1483](#1483))
([907bdae](907bdae))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Enhanced monitoring with support for upsizing tempo storage.
- Enabled reading secrets for datasources and configuring the service
graph in Grafana.
- Added options to set the code challenge and code_challenge_method for
Grafana and oauth2-proxy.
- Introduced an optional persistence configuration for tracing ingester
storage size.

- **Bug Fixes**
- Resolved an issue preventing installation of the chart under
unintended names.

- **Chores**
  - Updated helmrelease command for CRD updates.
  - Removed an unnecessary dashboard and adjusted descheduler syntax.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants