chore(common): add documentation about template usage#1426
Conversation
WalkthroughThe changes introduce a new comment block in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/common/templates/_telemetry.tpl (1)
35-40: Enhance Template DocumentationThe newly added comment block clearly documents the purpose and structure of the configuration dictionary returned for OpenTelemetry traces. It details the available keys (
enabled,host,port,endpoint,serviceProtocol,insecure) and offers important guidance—especially on the optional nature ofserviceProtocoland the need to castportto an integer. This addition improves the maintainability and clarity for developers using this template.A small nitpick: you might consider adding a brief note on when or why one might need to override these defaults (if applicable), just to further assist developers in understanding the intended usage scenarios.
3450109 to
df6443a
Compare
🤖 I have created a release *beep* *boop* --- ## [1.5.0](common-v1.4.0...common-v1.5.0) (2025-06-06) ### Features * **common/telemetry:** add telemetry-collector as a generic service name ([#1432](#1432)) ([fdf3b21](fdf3b21)) * **common:** add kube-apiserver networkpolicy helper ([#1413](#1413)) ([58ed072](58ed072)) ### Miscellaneous Chores * **common/dependencies:** update helm release common to v2.27.0 ([#1389](#1389)) ([9e7587f](9e7587f)) * **common:** add documentation about template usage ([#1426](#1426)) ([638add8](638add8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit