Skip to content

Conversation

@bwplotka
Copy link
Member

Signed-off-by: Bartek Plotka [email protected]

@bwplotka bwplotka requested review from domgreen and fabxc May 18, 2018 13:46
@@ -0,0 +1,64 @@
# Contributor Covenant Code of Conduct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- E2E tests for query part.
- Getting start, design & components documentation.
- Workflow tools (makefile) and CI file for Circle CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add at the last line?

[Unreleased]: https://github.com/improbable-eng/thanos/compare/v0.1.0-rc.0...HEAD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the first line?

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments that I would leave on a Prometheus release PR 🙂 . Feel free to ignore or apply as you like.

CHANGELOG.md Outdated
- Bucket commands.
- E2E tests for query part.
- Getting start, design & components documentation.
- Workflow tools (makefile) and CI file for Circle CI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant to users who want to use a release of Thanos

CHANGELOG.md Outdated
- Verify commands with potential fixes (experimental).
- Compact / Downsample offline commands.
- Bucket commands.
- E2E tests for query part.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant to users who want to use a release of Thanos

- Downsampling logic for Compactor (experimental).
- Rule (including alerts) evaluation logic for Ruler (experimental).
- StoreAPI logic for Ruler.
- Basic metric orchestration for all components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by this, can you elaborate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that all the components should have some metrics exposed that allows to measure the perf/success rate and alerting (:

CHANGELOG.md Outdated
- Compact / Downsample offline commands.
- Bucket commands.
- E2E tests for query part.
- Getting start, design & components documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd handle documentation out of band. People are not interested in changes in docs of a patch release. They should just (eventually) be available for each minor version release in rendered form and only the latest of each minor release.

Copy link
Contributor

@domgreen domgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bwplotka bwplotka merged commit d7e8416 into master May 18, 2018
@bwplotka bwplotka deleted the changelog branch May 18, 2018 15:29
fpetkovski added a commit to fpetkovski/thanos that referenced this pull request Oct 17, 2024
…o_modules-e7754cedc6

Bump github.com/docker/docker from 26.1.3+incompatible to 27.1.0+incompatible in the go_modules group across 1 directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants