-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: Added CHANGELOG & code of conduct before first release candidate. #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,64 @@ | |||
| # Contributor Covenant Code of Conduct | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| - E2E tests for query part. | ||
| - Getting start, design & components documentation. | ||
| - Workflow tools (makefile) and CI file for Circle CI. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add at the last line?
[Unreleased]: https://github.com/improbable-eng/thanos/compare/v0.1.0-rc.0...HEAD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in the first line?
brancz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments that I would leave on a Prometheus release PR 🙂 . Feel free to ignore or apply as you like.
CHANGELOG.md
Outdated
| - Bucket commands. | ||
| - E2E tests for query part. | ||
| - Getting start, design & components documentation. | ||
| - Workflow tools (makefile) and CI file for Circle CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not relevant to users who want to use a release of Thanos
CHANGELOG.md
Outdated
| - Verify commands with potential fixes (experimental). | ||
| - Compact / Downsample offline commands. | ||
| - Bucket commands. | ||
| - E2E tests for query part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not relevant to users who want to use a release of Thanos
| - Downsampling logic for Compactor (experimental). | ||
| - Rule (including alerts) evaluation logic for Ruler (experimental). | ||
| - StoreAPI logic for Ruler. | ||
| - Basic metric orchestration for all components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by this, can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just that all the components should have some metrics exposed that allows to measure the perf/success rate and alerting (:
CHANGELOG.md
Outdated
| - Compact / Downsample offline commands. | ||
| - Bucket commands. | ||
| - E2E tests for query part. | ||
| - Getting start, design & components documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd handle documentation out of band. People are not interested in changes in docs of a patch release. They should just (eventually) be available for each minor version release in rendered form and only the latest of each minor release.
Signed-off-by: Bartek Plotka <[email protected]>
domgreen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…o_modules-e7754cedc6 Bump github.com/docker/docker from 26.1.3+incompatible to 27.1.0+incompatible in the go_modules group across 1 directory
Signed-off-by: Bartek Plotka [email protected]