Merged
Conversation
| - run: yarn | ||
| - run: yarn lint | ||
| - run: yarn size | ||
| - run: NODE_OPTIONS=--openssl-legacy-provider yarn size |
Contributor
Author
There was a problem hiding this comment.
Added this to fix the following issue.

More Details here - webpack/webpack#14532
Owner
There was a problem hiding this comment.
Thanks. I was close to switch to old good Travis.
| "build": "rm -Rf ./dist && yarn build:es5 && yarn build:cjs", | ||
| "test": "npm run test:pick -- '_tests/**/*spec.js'", | ||
| "test:pick": "NODE_ENV=cjs mocha --require @babel/register --require jsdom-global/register --require _tests/spinup/scaffolding ", | ||
| "test:pick": "NODE_ENV=cjs mocha --require @babel/register --require jsdom-global/register --require _tests/spinup/scaffolding --exit", |
Contributor
Author
Owner
There was a problem hiding this comment.
OH, I was suffering from this for quite a while and was going to replace mocha by (a more common for me) jest next week.
Thank you!
Owner
|
🤝 |
theKashey
approved these changes
Dec 14, 2021
Contributor
Author
|
Thanks, what do we do about |
Contributor
Author
|
Please ping me here once a new version is released with this change. Thanks |
Owner
|
2.7.1 has been just released. |
Contributor
Author
|
Yay! party! |
Contributor
Author
|
also, confirmed the prevent scroll is working with this release. Thanks |
nickspaargaren
pushed a commit
to nickspaargaren/react-focus-lock
that referenced
this pull request
Dec 11, 2024
…focus Update focus-lock version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #162
@theKashey We would also need to bump the focus-lock version to fix the above issue.