Skip to content

Update focus-lock version#186

Merged
theKashey merged 4 commits intotheKashey:masterfrom
abhimanyu-singh-uber:abhi-bump-focus
Dec 14, 2021
Merged

Update focus-lock version#186
theKashey merged 4 commits intotheKashey:masterfrom
abhimanyu-singh-uber:abhi-bump-focus

Conversation

@abhimanyu-singh-uber
Copy link
Copy Markdown
Contributor

Fixes #162

@theKashey We would also need to bump the focus-lock version to fix the above issue.

- run: yarn
- run: yarn lint
- run: yarn size
- run: NODE_OPTIONS=--openssl-legacy-provider yarn size
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to fix the following issue.
image
More Details here - webpack/webpack#14532

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was close to switch to old good Travis.

"build": "rm -Rf ./dist && yarn build:es5 && yarn build:cjs",
"test": "npm run test:pick -- '_tests/**/*spec.js'",
"test:pick": "NODE_ENV=cjs mocha --require @babel/register --require jsdom-global/register --require _tests/spinup/scaffolding ",
"test:pick": "NODE_ENV=cjs mocha --require @babel/register --require jsdom-global/register --require _tests/spinup/scaffolding --exit",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the following issue with yarn test just being stuck and timing out after completing the tests.
image

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH, I was suffering from this for quite a while and was going to replace mocha by (a more common for me) jest next week.
Thank you!

@theKashey theKashey merged commit 14a6d11 into theKashey:master Dec 14, 2021
@theKashey
Copy link
Copy Markdown
Owner

🤝

@abhimanyu-singh-uber
Copy link
Copy Markdown
Contributor Author

Thanks, what do we do about 2.7.0 version? let it stay on npm ?

@abhimanyu-singh-uber
Copy link
Copy Markdown
Contributor Author

Please ping me here once a new version is released with this change. Thanks

@theKashey
Copy link
Copy Markdown
Owner

2.7.1 has been just released.
2.7.0 will be deprecated soon after

@abhimanyu-singh-uber
Copy link
Copy Markdown
Contributor Author

Yay! party!

@abhimanyu-singh-uber
Copy link
Copy Markdown
Contributor Author

also, confirmed the prevent scroll is working with this release. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] preventScroll Option on Focus Override

2 participants