fix: correct Context instability leading to hydration failure#395
Merged
Conversation
Owner
theKashey
commented
Nov 29, 2025
theKashey
commented
- Fixes problem earlier reported as Focus lock suspense error in SSR #377
- Reimplements fix proposed in fix: ssr suspense error #388
- secures correct behavior via extra stability test
theKashey
commented
Nov 29, 2025
|
|
||
| // Desired behaviour: FocusLock should not cause React hydration update warnings | ||
| const hasHydrationFailure = messages.some(msg => | ||
| msg.includes('This Suspense boundary received an update before it finished hydrating') |
Owner
Author
There was a problem hiding this comment.
it was causing the problem. @ExLineP 🤝 for reporting it
theKashey
commented
Nov 29, 2025
| get active() { | ||
| return isActive.current; | ||
| }, | ||
| }), [disabled, isActive, shards, observed]); |
Owner
Author
There was a problem hiding this comment.
all the fix required:
- half of these values is actually never used
- the ones used are totally happy working with refs
Owner
Author
|
Released in v2.13.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.