Closed
Conversation
|
@shinokada is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThe PR adds a SplitPane feature (Pane and Divider components and metadata), renames internal module paths from Changes
Sequence Diagram(s)sequenceDiagram
participant App as App (consumer)
participant Split as SplitPane
participant PaneA as Pane (index N)
participant Divider as Divider (index N)
Note over App,Split: Mount split pane with children panes
App->>Split: render(children)
Split-->>PaneA: provide context (register paneIndex, styles)
PaneA->>Split: request paneStyle / shouldRenderDivider
Split-->>PaneA: paneStyle, showDivider?
alt showDivider
PaneA->>Divider: render Divider(direction, index, currentSize)
Note right of Divider: user interaction (mouse down / key)
App->>Divider: onMouseDown / onKeyDown events
Divider->>Split: emit drag start / resize events
Split-->>PaneA: update sizes via context
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (63)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/ISSUE_TEMPLATE/bug_report.yml(1 hunks).github/pull_request_template.md(1 hunks)src/lib/index.ts(1 hunks)src/lib/theme/themes.ts(1 hunks)src/routes/docs-examples/extend/kanban-board/Default.svelte(0 hunks)src/routes/docs/extend/split-pane.md(1 hunks)
💤 Files with no reviewable changes (1)
- src/routes/docs-examples/extend/kanban-board/Default.svelte
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/ISSUE_TEMPLATE/bug_report.yml
[error] 25-25: syntax error: expected , but found '-'
(syntax)
[error] 27-27: duplication of key "attributes" in mapping
(key-duplicates)
[error] 42-42: duplication of key "validations" in mapping
(key-duplicates)
🔇 Additional comments (4)
.github/pull_request_template.md (1)
1-71: LGTM! Excellent improvements to PR template structure and guidance.The revised template provides much clearer guidance with better organization, helpful placeholders, and a more comprehensive checklist. The addition of CoderabbitAI review confirmation and accessibility checks strengthens the review process.
.github/ISSUE_TEMPLATE/bug_report.yml (1)
1-23: Excellent enhancements to bug report template structure.The revised template significantly improves bug report quality with:
- Clearer field descriptions and examples
- Required minimal reproduction with playground link
- Structured environment information collection
- New debugging fields (Logs, Screenshots, Additional Context)
- Quality checklist to ensure complete submissions
These changes will help maintainers triage and resolve issues more efficiently.
Also applies to: 57-108
src/lib/theme/themes.ts (1)
83-83: Theme file verified at new export path.The export path in
src/lib/themes/themes.tscorrectly references$lib/split-pane/theme, which resolves tosrc/lib/split-pane/theme.ts. No issues found.src/routes/docs/extend/split-pane.md (1)
15-15: Divider component export verified—documentation is accurate.The script confirms that
Divideris properly exported from the split-pane module (export { default as Divider } from "./Divider.svelte"), andDividerHitAreais also available asdividerHitAreafrom the theme exports. The documentation addition correctly reflects the available components.
Comment on lines
+25
to
+56
| - type: textarea | ||
| id: reproduction | ||
| attributes: | ||
| label: Reproduction | ||
| label: Minimal Reproduction | ||
| description: | | ||
| Please provide a **minimal code example** that demonstrates the problem. This should be self-contained, minimal, and runnable. | ||
|
|
||
| Include: | ||
| - What you expected to happen | ||
| - What actually happens instead | ||
| - Complete code example (copy/paste ready) | ||
| - Any specific steps to trigger the issue | ||
| Provide a ***copy-paste-ready*** minimal example that reproduces the bug. | ||
| ✅ Preferred: Fork this template and modify it to show the issue: | ||
| https://svelte.dev/playground/47df97f4370f43fbb008c708fd5a7b8a?version=5.43.2 | ||
| ✅ OK: Full code sample in the box below | ||
| ❌ Not accepted: screenshots of code, descriptions without code, full repositories | ||
|
|
||
| Issues with vague descriptions and no reproduction code will receive a "needs reproduction" label and may be closed if not provided within a reasonable timeframe. | ||
| placeholder: "Provide your minimal code example here..." | ||
| Issues without a working reproduction may be closed. | ||
| placeholder: | | ||
| // Your minimal code example here... | ||
| // or paste your modified REPL link: | ||
| // https://svelte.dev/playground/... | ||
| render: typescript | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: steps | ||
| attributes: | ||
| label: Steps to Reproduce | ||
| description: "List the exact actions needed to trigger the bug." | ||
| placeholder: | | ||
| 1. Install flowbite-svelte@latest | ||
| 2. Use Button inside Modal | ||
| 3. Click button → nothing happens | ||
| validations: | ||
| required: true | ||
|
|
Contributor
There was a problem hiding this comment.
Fix YAML syntax error: incorrect indentation.
The YAML has a critical syntax error at line 25. The list item - type: textarea should be indented with 2 spaces before the dash to align with line 12, not 4 spaces. This will cause the GitHub issue template to fail parsing.
Apply this diff to fix the indentation:
- - type: textarea
+ - type: textarea
id: reproductionAlso verify the indentation for the "Steps to Reproduce" section (lines 45-55) is correct after fixing line 25.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - type: textarea | |
| id: reproduction | |
| attributes: | |
| label: Reproduction | |
| label: Minimal Reproduction | |
| description: | | |
| Please provide a **minimal code example** that demonstrates the problem. This should be self-contained, minimal, and runnable. | |
| Include: | |
| - What you expected to happen | |
| - What actually happens instead | |
| - Complete code example (copy/paste ready) | |
| - Any specific steps to trigger the issue | |
| Provide a ***copy-paste-ready*** minimal example that reproduces the bug. | |
| ✅ Preferred: Fork this template and modify it to show the issue: | |
| https://svelte.dev/playground/47df97f4370f43fbb008c708fd5a7b8a?version=5.43.2 | |
| ✅ OK: Full code sample in the box below | |
| ❌ Not accepted: screenshots of code, descriptions without code, full repositories | |
| Issues with vague descriptions and no reproduction code will receive a "needs reproduction" label and may be closed if not provided within a reasonable timeframe. | |
| placeholder: "Provide your minimal code example here..." | |
| Issues without a working reproduction may be closed. | |
| placeholder: | | |
| // Your minimal code example here... | |
| // or paste your modified REPL link: | |
| // https://svelte.dev/playground/... | |
| render: typescript | |
| validations: | |
| required: true | |
| - type: textarea | |
| id: steps | |
| attributes: | |
| label: Steps to Reproduce | |
| description: "List the exact actions needed to trigger the bug." | |
| placeholder: | | |
| 1. Install flowbite-svelte@latest | |
| 2. Use Button inside Modal | |
| 3. Click button → nothing happens | |
| validations: | |
| required: true | |
| - type: textarea | |
| id: reproduction | |
| attributes: | |
| label: Minimal Reproduction | |
| description: | | |
| Provide a ***copy-paste-ready*** minimal example that reproduces the bug. | |
| ✅ Preferred: Fork this template and modify it to show the issue: | |
| https://svelte.dev/playground/47df97f4370f43fbb008c708fd5a7b8a?version=5.43.2 | |
| ✅ OK: Full code sample in the box below | |
| ❌ Not accepted: screenshots of code, descriptions without code, full repositories | |
| Issues without a working reproduction may be closed. | |
| placeholder: | | |
| // Your minimal code example here... | |
| // or paste your modified REPL link: | |
| // https://svelte.dev/playground/... | |
| render: typescript | |
| validations: | |
| required: true | |
| - type: textarea | |
| id: steps | |
| attributes: | |
| label: Steps to Reproduce | |
| description: "List the exact actions needed to trigger the bug." | |
| placeholder: | | |
| 1. Install flowbite-svelte@latest | |
| 2. Use Button inside Modal | |
| 3. Click button → nothing happens | |
| validations: | |
| required: true |
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 25-25: syntax error: expected , but found '-'
(syntax)
[error] 27-27: duplication of key "attributes" in mapping
(key-duplicates)
[error] 42-42: duplication of key "validations" in mapping
(key-duplicates)
🤖 Prompt for AI Agents
.github/ISSUE_TEMPLATE/bug_report.yml around lines 25 to 56: the YAML list item
starting at line 25 is misindented (uses 4 spaces before the dash) which breaks
the template parsing; fix by reducing indentation so the dash aligns with the
other top-level list items (use 2 spaces before the dash), then ensure the
nested keys (type, id, attributes, validations) remain properly indented
relative to that dash; after adjusting line 25 re-check and correct indentation
for the "Steps to Reproduce" block (lines ~45-55) so its leading dash and nested
fields follow the same top-level alignment.
src/lib/index.ts
Outdated
| export * from "./virtuallist"; | ||
| export * from "./kanban"; | ||
| export * from "./splitpane"; No newline at end of file | ||
| export * from "./split-pane"; No newline at end of file |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
Verify this breaking change and document migration path.
Renaming the module path from ./splitpane to ./split-pane is a breaking change for external consumers. Ensure:
- The directory
src/lib/split-pane/exists with all expected exports - All internal imports have been updated consistently
- This breaking change is documented in the PR description with migration guidance
Run the following script to verify the directory structure and check for any remaining references to the old path:
🏁 Script executed:
#!/bin/bash
# Verify the new split-pane directory exists and check for old path references
# Check if new directory exists
if [ -d "src/lib/split-pane" ]; then
echo "✓ New directory src/lib/split-pane/ exists"
echo "Files in directory:"
fd . src/lib/split-pane --type f
else
echo "✗ ERROR: Directory src/lib/split-pane/ not found"
fi
echo ""
echo "Checking for any remaining references to old 'splitpane' path:"
# Search for imports/requires of the old path (exclude this change)
rg -n "from ['\"].*splitpane['\"]" --type ts --type js --type svelte -g '!src/lib/index.ts' -g '!src/lib/theme/themes.ts'
rg -n "import.*splitpane" --type ts --type js --type svelte -g '!src/lib/index.ts' -g '!src/lib/theme/themes.ts'Length of output: 345
🏁 Script executed:
#!/bin/bash
# Search for any remaining references to the old 'splitpane' path
# Using pattern search without file type filters to catch all occurrences
echo "Searching for old 'splitpane' path references in the codebase:"
rg -n "splitpane" --type ts --type js -g '!node_modules' -g '!dist' -g '!.svelte-kit' 2>/dev/null || echo "No matches found with TS/JS filter"
echo ""
echo "Alternative search without type restriction:"
rg -rn "splitpane" --glob '!node_modules' --glob '!dist' --glob '!.svelte-kit' 2>/dev/null | head -20 || echo "No matches found"
echo ""
echo "Verifying split-pane exports are correct in index.ts:"
cat src/lib/split-pane/index.tsLength of output: 1285
🏁 Script executed:
#!/bin/bash
# Verify the main index.ts file exports from the correct path
echo "Checking src/lib/index.ts for split-pane export:"
rg -n "export.*split-pane" src/lib/index.ts 2>/dev/null || echo "Direct export check"
# Also check if old path still exists anywhere
echo ""
echo "Checking if old splitpane directory exists:"
ls -la src/lib/ 2>/dev/null | grep -i split || echo "No split directory found"
# Verify the actual line 92 content
echo ""
echo "Content around line 92 of src/lib/index.ts:"
rg -n "." src/lib/index.ts | grep -E "^(9[0-2]|9[1-3]):" | tail -5Length of output: 329
🏁 Script executed:
#!/bin/bash
# Look for CHANGELOG, PR description, or migration documentation
echo "Looking for documentation of breaking changes:"
find . -maxdepth 2 -type f \( -name "CHANGELOG*" -o -name "MIGRATION*" -o -name "BREAKING*" -o -name "CHANGES*" \) ! -path "./node_modules/*" ! -path "./.git/*" 2>/dev/null
echo ""
echo "Checking if PR body or description file exists:"
ls -la .github/ 2>/dev/null | head -10 || echo "No .github directory"Length of output: 423
🏁 Script executed:
#!/bin/bash
# Check CHANGELOG for documentation of the splitpane breaking change
echo "Searching CHANGELOG.md for split-pane or splitpane references:"
rg -n "split-pane|splitpane" CHANGELOG.md -A 2 -B 2
echo ""
echo "Also checking recent entries in CHANGELOG for any breaking changes:"
head -50 CHANGELOG.mdLength of output: 1171
Update CHANGELOG.md to document the breaking change and provide migration guidance.
The module path renaming from ./splitpane to ./split-pane is properly implemented—the directory exists with all expected files, internal imports are consistent, and no old path references remain. However, this breaking change is not documented in CHANGELOG.md. Add an entry documenting the rename with a migration note for external consumers upgrading to this version (e.g., "Update imports from 'package/splitpane' to 'package/split-pane'").
🤖 Prompt for AI Agents
In src/lib/index.ts around line 92, the export was changed from "./splitpane" to
"./split-pane" but the breaking change is not documented; update CHANGELOG.md by
adding a breaking-change entry (under Unreleased or the current release heading)
that states the module was renamed from 'splitpane' to 'split-pane' and include
a short migration note showing the import update (e.g., "Update imports from
'package/splitpane' to 'package/split-pane'") and any version or compatibility
notes consumers need when upgrading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
Status
✅ Checks
api-checkdirectory as requiredpnpm check && pnpm test:e2eℹ Additional Information
Summary by CodeRabbit
New Features
Documentation
Refactor
Chores