feat: add resetViewOnly prop to retain data but reset map position#496
Merged
jessicamcinchak merged 1 commit intomainfrom Sep 6, 2024
Merged
feat: add resetViewOnly prop to retain data but reset map position#496jessicamcinchak merged 1 commit intomainfrom
resetViewOnly prop to retain data but reset map position#496jessicamcinchak merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ianjon3s
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, the "Reset" control is responsible for two things:
drawModeis enabledThis adds a new prop
resetViewOnlythat allows us to still show a "Reset" control when indrawMode, but retain data when clicked and only reset the map viewport. This is useful if you want a "Remove" button to live in another part of your UI - like we're doing in PlanX here theopensystemslab/planx-new#3625