build(deps): bump @turf/union from 7.0.0 to 7.1.0#504
Conversation
dependabot
bot
added
dependencies
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DafyddLlyr
force-pushed
the
dependabot/npm_and_yarn/turf/union-7.1.0
branch
2 times, most recently
from
49b9cca to
58ea0ff
Compare
| if (this.showGeojsonDataMarkers) { | ||
| this.geojsonData.features.forEach((feature: GeoJSONFeature) => { | ||
| this.geojsonData.features.forEach((feature) => { | ||
| if (feature.geometry.type !== "Point") return; |
| const allFeatures = featureSource | ||
| .getFeatures() | ||
| .map((feature) => geojson.writeFeatureObject(feature)) | ||
| .filter((feature): feature is Feature<Polygon | MultiPolygon> => |
There was a problem hiding this comment.
This filter() is required for type narrowing.
| geojson.readFeature( | ||
| featureSource.getFeatures().reduce((acc: any, curr) => { | ||
| const toMerge = geojson.writeFeatureObject(curr).geometry; | ||
| return acc ? union(acc, toMerge) : toMerge; |
There was a problem hiding this comment.
There was a problem hiding this comment.
I've not actually tested this though as I'm getting blocked network requests locally. Still looking into this!
There was a problem hiding this comment.
FYI think our use of OS Features API has maybe been out of whack for a bit beyond Turf changes here ! Sorry didn't log this as issue sooner - may not be terrible solution to mark clickFeatures and other reliant props as @deprecated in meantime and log as Github Issue to revisit/reimplement?
Think we'll need to come back to some variation of this feature eventually for applications with multiple address (eg union title boundaries).
jessicamcinchak
left a comment
jessicamcinchak
left a comment
There was a problem hiding this comment.
Thanks for picking these up & getting to bottom of XML filter issue !
Bumps [@turf/union](https://github.com/Turfjs/turf) from 7.0.0 to 7.1.0. - [Release notes](https://github.com/Turfjs/turf/releases) - [Changelog](https://github.com/Turfjs/turf/blob/master/CHANGELOG.md) - [Commits](Turfjs/turf@v7.0.0...v7.1.0) --- updated-dependencies: - dependency-name: "@turf/union" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
DafyddLlyr
force-pushed
the
dependabot/npm_and_yarn/turf/union-7.1.0
branch
from
06d5140 to
76694bb
Compare
2 participants
Bumps @turf/union from 7.0.0 to 7.1.0.
Release notes
Sourced from
@turf/union's releases.... (truncated)
Changelog
Sourced from
@turf/union's changelog.Commits
68915eev7.1.0948cdafUpgrade pnpm/action-setup in github actions (#2696)5f0d405Clarify behavior of some existing turf modules (#2683)ad8012cchore: update cluster-dbscan docs (#2624)36cdb9fRevert@turf/kinksto 6.5.0 version (#2693)df7e42fFix@turf/maskbenchmarks to exclude test fixtures that are not usable (#2692)c470ea4Add test.example.js to the prettier ignore list because it is a generated fil...7275eb9Stop turf-mask mutating by default, make it an option (#2635)c8f24e0Update@types/geojsonto 7946.0.10 minimum (#2688)25917d8Rework prettier setup (#2677)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)