Skip to content

wip: fix map web component loading bugs#704

Closed
jessicamcinchak wants to merge 6 commits intomainfrom
jess/map-wrappers
Closed

wip: fix map web component loading bugs#704
jessicamcinchak wants to merge 6 commits intomainfrom
jess/map-wrappers

Conversation

@jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Nov 18, 2021

suspect that this is a challenge related to how Lit web components unmount/reload when integrated in React - guessing all bugs below will have same solution once we get to the bottom of it:

  1. visual bug in FindProperty component related to back button behavior where previous OS Feature will still appear on map after searching a new address. Reload's correctly if you "restart application" rather than go-back. No passport implications, but visually confusing to user
  1. visual bug in DrawBoundary component related to back button behavior where two polygons are rendered on top of each other, but you can only modify one of them. Again, no passport implications (area & geojson are correctly calculated still), but visually confusing
  1. DrawBoundary map fails to re-render with new props when radio button is toggled/state changes wip: click-to-select *or* draw a site boundary #688

maybe useful resources:

@jessicamcinchak
Copy link
Member Author

closing in favor of #803 !

@jessicamcinchak jessicamcinchak deleted the jess/map-wrappers branch January 14, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant