feat: add bloom wallet#2209
Conversation
packages/bloom/package.json
Outdated
| @@ -0,0 +1,77 @@ | |||
| { | |||
| "name": "@web3-onboard/bloom", | |||
| "version": "2.1.2", | |||
There was a problem hiding this comment.
| "version": "2.1.2", | |
| "version": "2.0.0-alpha.1", |
|
Hi @MarkNerdi it looks like the build is failing within the PR status checks - can you have a look when you get a moment? |
|
@Adamj1232 |
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
|
@MarkNerdi local testing and build went well. I formatted the files and added the bloom module to the internal demo - |
|
@Adamj1232 |
|
@MarkNerdi code is looking good! When testing locally I am getting the following error: |
|
@Adamj1232 This error occurs when you dont have bloom installed on you machine. Do you have an example in your project where a wallet prompts the user to download it? i could add that |
@MarkNerdi ah gotcha, yeah we would def want to display a download message so users can add Bloom if they want - here is an example to display that message formatted using a helper function - https://github.com/blocknative/web3-onboard/blob/eb205fb5356b6851afb764e42f06ac97b45052d2/packages/okx/src/index.ts#L35 |
|
@Adamj1232 |
Adamj1232
left a comment
There was a problem hiding this comment.
Looks good! Thanks for contributing to W3O!

Description
This PR add Bloom wallet to the list of supported wallets
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)