Skip to content

Add null check to prevent potential runtime errors#2319

Merged
Adamj1232 merged 3 commits intothirdweb-dev:developfrom
sigmoidr:patch-1
Dec 27, 2024
Merged

Add null check to prevent potential runtime errors#2319
Adamj1232 merged 3 commits intothirdweb-dev:developfrom
sigmoidr:patch-1

Conversation

@sigmoidr
Copy link
Copy Markdown
Contributor

@sigmoidr sigmoidr commented Dec 4, 2024

helpers.ts:

-    return !!provider.providers?.some(provider => checkProviderIdentity({ provider, device }));
+    return Array.isArray(provider.providers) && !!provider.providers.some(provider => checkProviderIdentity({ provider, device }));

wallets.ts:

-    checkProviderIdentity: ({ provider }) => !!provider && !!provider['ethereum'][ProviderIdentityFlag.Bitget],
+    checkProviderIdentity: ({ provider }) => !!provider && !!provider['ethereum'] && !!provider['ethereum'][ProviderIdentityFlag.Bitget]

Copy link
Copy Markdown
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This null check looks good and passes testing

@Adamj1232 Adamj1232 merged commit 9db4d8e into thirdweb-dev:develop Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants