chore: upgrade WalletConnect dependencies#2385
Merged
joaquim-verges merged 3 commits intothirdweb-dev:developfrom Oct 9, 2025
Merged
chore: upgrade WalletConnect dependencies#2385joaquim-verges merged 3 commits intothirdweb-dev:developfrom
joaquim-verges merged 3 commits intothirdweb-dev:developfrom
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughVersion bumped for the walletconnect package and updates to one runtime dependency and one devDependency in package.json. No code or API surface changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
joaquim-verges
approved these changes
Oct 9, 2025
joaquim-verges
added a commit
that referenced
this pull request
Oct 9, 2025
* Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon * Chore: update git pages action (#2375) * fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb * chore: git action to push to main + docs (#2378) * chore: git action to push to main + docs * lint * chore: fix footer size/colors (#2379) * chore: fix footer size/colors * remove push to prod action * chore: remove blocknative links from header (#2381) * chore: upgrade WalletConnect dependencies (#2385) * chore: upgrade WalletConnect dependencies * chore: upgrade version * bump version --------- Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com> Co-authored-by: Phillip Ho <arcoraven@gmail.com> Co-authored-by: Derek <alexanderderekrein@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
web3onboard makes use of WalletConnect
requiredNamespaceswhich breaks some use cases and customers e.g. Safe{Wallet}. Newer versions of WalletConnect translaterequiredNamespacesautomatically intooptionalNamespaces. I've decided to upgrade the WalletConnect dependency to latest instead of removing the use ofrequiredNamespacesas there are many other improvements in the more recent versions of the WalletConnect adapter.PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)
Summary by CodeRabbit
Chores
Dependencies
Bug Fixes
Notes